From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4999 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/3] bits/socket.h: Define SO_RCVBUFFORCE for mips Date: Wed, 30 Apr 2014 14:48:47 -0400 Message-ID: <20140430184847.GL26358@brightrain.aerifal.cx> References: <1398649434-23560-1-git-send-email-raj.khem@gmail.com> <20140428142935.GZ26358@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1398883748 18618 80.91.229.3 (30 Apr 2014 18:49:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Apr 2014 18:49:08 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-5003-gllmg-musl=m.gmane.org@lists.openwall.com Wed Apr 30 20:49:00 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1WfZYy-0004My-47 for gllmg-musl@plane.gmane.org; Wed, 30 Apr 2014 20:49:00 +0200 Original-Received: (qmail 1966 invoked by uid 550); 30 Apr 2014 18:48:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 1958 invoked from network); 30 Apr 2014 18:48:59 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:4999 Archived-At: On Mon, Apr 28, 2014 at 07:54:26AM -0700, Khem Raj wrote: > On Mon, Apr 28, 2014 at 7:29 AM, Rich Felker wrote: > > On Sun, Apr 27, 2014 at 06:43:52PM -0700, Khem Raj wrote: > >> packages like udev are using it > >> > >> Signed-off-by: Khem Raj > >> > >> Upstream-Status: Pending > >> --- > >> arch/mips/bits/socket.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/mips/bits/socket.h b/arch/mips/bits/socket.h > >> index ba79045..2264679 100644 > >> --- a/arch/mips/bits/socket.h > >> +++ b/arch/mips/bits/socket.h > >> @@ -31,6 +31,7 @@ struct cmsghdr > >> #define SO_RCVBUF 0x1002 > >> #define SO_KEEPALIVE 8 > >> #define SO_OOBINLINE 256 > >> +#define SO_RCVBUFFORCE 33 > >> > >> #define SO_NO_CHECK 11 > >> #define SO_PRIORITY 12 > >> -- > >> 1.7.10.4 > > > > I think this is correct, but are there additional new SO_*'s that > > should be added to mips, or is this value the same as on other archs > > and perhaps not something that should be arch-specific to begin with? > > I think redefining them in mips specific sockets.h is not needed. it > could use the values > from sys/socket.h On further review, this value doesn't seem mips-specific, but the also-missing SO_SNDBUFFORCE is mips-specific in value. :( So I'm just adding both to the mips version. Cleanup can come later. Rich