From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Cc: Pawel Dziepak <pdziepak@quarnos.org>
Subject: Re: [PATCH] add definition of max_align_t to stddef.h
Date: Wed, 30 Apr 2014 23:42:51 +0200 [thread overview]
Message-ID: <20140430214250.GI12324@port70.net> (raw)
In-Reply-To: <1398889381-22981-1-git-send-email-pdziepak@quarnos.org>
* Pawel Dziepak <pdziepak@quarnos.org> [2014-04-30 22:23:01 +0200]:
>
> +TYPEDEF union { long double ld; long long ll; } max_align_t;
this is wrong
- ld and ll identifiers are not reserved for the implementation
(you could name them _ld, _ll or __ld, __ll etc)
and see previous max_align_t discussion
http://www.openwall.com/lists/musl/2014/04/28/8
- compiler implementations are non-conforming on some platforms
(_Alignof returns inconsistent results for the same object type so
reasoning about alignments is problematic, there are exceptions
where this is allowed in c++11 but not in c11)
- max_align_t is part of the abi and your solution is incompatible
with gcc and clang (your definition gives 4 byte _Alignof(max_align_t)
on i386 instead of 8)
there is probably not much choice and musl will have to copy the
silly definition used in gcc/clang making max_align_t not very
useful (it does not reflect malloc alignment supported by the libc
nor the object alignments supported by the compiler)
next prev parent reply other threads:[~2014-04-30 21:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 20:23 Pawel Dziepak
2014-04-30 21:42 ` Szabolcs Nagy [this message]
2014-04-30 22:43 ` Rich Felker
2014-05-04 2:52 ` Paweł Dziepak
2014-05-04 11:42 ` Paweł Dziepak
2014-05-07 5:02 ` Jens Gustedt
2014-05-04 2:36 ` Paweł Dziepak
2014-05-04 5:02 ` Rich Felker
2014-05-06 10:35 Paweł Dziepak
2014-05-07 3:13 ` Rich Felker
2014-05-07 4:14 ` Luca Barbato
2014-05-07 4:29 ` Rich Felker
2014-05-07 5:12 ` Luca Barbato
2014-05-07 22:48 ` Rich Felker
2014-05-08 12:07 ` Luca Barbato
2014-05-08 14:25 ` Rich Felker
2014-05-07 9:28 ` Paweł Dziepak
2014-05-07 23:07 ` Rich Felker
2014-05-08 10:57 ` Szabolcs Nagy
2014-05-08 14:11 ` Rich Felker
2014-05-08 16:41 ` Paweł Dziepak
2014-05-08 17:41 ` Rich Felker
2014-05-08 18:45 ` Jens Gustedt
2014-05-08 19:11 ` Paweł Dziepak
2014-05-08 19:22 ` Jens Gustedt
2014-05-08 19:45 ` Paweł Dziepak
2014-05-08 20:02 ` Rich Felker
2014-05-08 20:45 ` Paweł Dziepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430214250.GI12324@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
--cc=pdziepak@quarnos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).