Re: __xmknod, __sysv_signal

[Rich Felker <dalias@libc.org>]

Sorry for taking a while to review this. I'd like to get it committed,
but a few questions...

On Fri, Apr 18, 2014 at 10:11:02PM -0500, M Farkas-Dyck wrote:
> ---
>  src/stat/__xmknod.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 src/stat/__xmknod.c
> 
> diff --git a/src/stat/__xmknod.c b/src/stat/__xmknod.c
> new file mode 100644
> index 0000000..62499de
> --- /dev/null
> +++ b/src/stat/__xmknod.c
> @@ -0,0 +1,6 @@
> +#include <sys/stat.h>
> +
> +int __xmknod(int ver, const char *path, mode_t mode, dev_t *dev)
> +{
> +	return mknod (path, mode, dev);
> +}

I think this should be *dev or something; mknod takes dev_t, not
dev_t*.

Also I don't really like having this in src/stat, but we don't really
have a dedicated place for ABI-compat junk yet...

> ---
>  src/signal/signal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/signal/signal.c b/src/signal/signal.c
> index c0f063e..29e03c8 100644
> --- a/src/signal/signal.c
> +++ b/src/signal/signal.c
> @@ -13,3 +13,4 @@ void (*signal(int sig, void (*func)(int)))(int)
>  }
> 
>  weak_alias(signal, bsd_signal);
> +weak_alias(signal, __sysv_signal);
> -- 
> 1.8.5.2

Probably ok.

Rich