From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5004 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: __xmknod, __sysv_signal Date: Wed, 30 Apr 2014 20:32:28 -0400 Message-ID: <20140501003228.GQ26358@brightrain.aerifal.cx> References: <20140419025204.GS26358@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1398904368 12087 80.91.229.3 (1 May 2014 00:32:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 May 2014 00:32:48 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-5008-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 01 02:32:41 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1WfevZ-0007SJ-B4 for gllmg-musl@plane.gmane.org; Thu, 01 May 2014 02:32:41 +0200 Original-Received: (qmail 21613 invoked by uid 550); 1 May 2014 00:32:40 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 21605 invoked from network); 1 May 2014 00:32:40 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:5004 Archived-At: Sorry for taking a while to review this. I'd like to get it committed, but a few questions... On Fri, Apr 18, 2014 at 10:11:02PM -0500, M Farkas-Dyck wrote: > --- > src/stat/__xmknod.c | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 src/stat/__xmknod.c > > diff --git a/src/stat/__xmknod.c b/src/stat/__xmknod.c > new file mode 100644 > index 0000000..62499de > --- /dev/null > +++ b/src/stat/__xmknod.c > @@ -0,0 +1,6 @@ > +#include > + > +int __xmknod(int ver, const char *path, mode_t mode, dev_t *dev) > +{ > + return mknod (path, mode, dev); > +} I think this should be *dev or something; mknod takes dev_t, not dev_t*. Also I don't really like having this in src/stat, but we don't really have a dedicated place for ABI-compat junk yet... > --- > src/signal/signal.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/signal/signal.c b/src/signal/signal.c > index c0f063e..29e03c8 100644 > --- a/src/signal/signal.c > +++ b/src/signal/signal.c > @@ -13,3 +13,4 @@ void (*signal(int sig, void (*func)(int)))(int) > } > > weak_alias(signal, bsd_signal); > +weak_alias(signal, __sysv_signal); > -- > 1.8.5.2 Probably ok. Rich