From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5490 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] implement issetugid(2) (v3) Date: Tue, 15 Jul 2014 12:45:46 -0400 Message-ID: <20140715164546.GE17402@brightrain.aerifal.cx> References: <1405438846-21908-1-git-send-email-bcook@openbsd.org> <20140715161657.GA9928@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1405442768 22830 80.91.229.3 (15 Jul 2014 16:46:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Jul 2014 16:46:08 +0000 (UTC) To: Brent Cook , musl@lists.openwall.com, beck@openbsd.org, Brent Cook Original-X-From: musl-return-5495-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jul 15 18:46:01 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1X75rc-0004ny-Lw for gllmg-musl@plane.gmane.org; Tue, 15 Jul 2014 18:46:00 +0200 Original-Received: (qmail 26449 invoked by uid 550); 15 Jul 2014 16:45:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 26441 invoked from network); 15 Jul 2014 16:45:59 -0000 Content-Disposition: inline In-Reply-To: <20140715161657.GA9928@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:5490 Archived-At: On Tue, Jul 15, 2014 at 06:16:57PM +0200, Szabolcs Nagy wrote: > * Brent Cook [2014-07-15 15:40:46 +0000]: > > --- a/include/unistd.h > > +++ b/include/unistd.h > > @@ -192,6 +192,10 @@ int euidaccess(const char *, int); > > int eaccess(const char *, int); > > #endif > > > > +#ifdef _BSD_SOURCE > > +int issetugid(void); > > +#endif > > + > > in musl _BSD_SOURCE is a subset of _GNU_SOURCE > so it should be used with || defined(_GNU_SOURCE) > > (_GNU_SOURCE actually means 'everything' instead of > 'gnu', and _BSD_SOURCE means 'default', but they are > very close to the usual gnu/bsd feature set applications > expect Yes. I think we should go ahead and change the names to _DEFAULT_SOURCE and _ALL_SOURCE and put the remapping from _BSD_SOURCE and _GNU_SOURCE into features.h. This would eliminate confusion about whether something should be BSD or BSD|GNU. Rich