From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5491
Path: news.gmane.org!not-for-mail
From: Isaac Dunham <ibid.ag@gmail.com>
Newsgroups: gmane.linux.lib.musl.general,gmane.linux.distributions.alpine.devel
Subject: what should be done with SA_INTERRUPT? (gpm 1.20.7)
Date: Tue, 15 Jul 2014 18:16:47 -0700
Message-ID: <20140716011646.GA1179@newbook>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1405448230 3706 80.91.229.3 (15 Jul 2014 18:17:10 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 15 Jul 2014 18:17:10 +0000 (UTC)
To: musl@lists.openwall.com, alpine-devel@lists.alpinelinux.org
Original-X-From: musl-return-5496-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jul 15 20:17:04 2014
Return-path: <musl-return-5496-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-5496-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1X77Hj-00087R-D5
	for gllmg-musl@plane.gmane.org; Tue, 15 Jul 2014 20:17:03 +0200
Original-Received: (qmail 3317 invoked by uid 550); 15 Jul 2014 18:17:02 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 3308 invoked from network); 15 Jul 2014 18:17:02 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:subject:message-id:mime-version:content-type
         :content-disposition:user-agent;
        bh=f8z5fi9yEoyaaiDlWC8M8CLs+Wq8aKjVC2uBAXRXoqY=;
        b=w/xlQ56Z9+Eo8QiDnltvl07NgN7YCV4ez7aNdxuaBSRjyH6DcwPxDoBUZ1rgQ/qHXV
         fir9EP8FoGqKdSIGHaaf8SnFJWgdgOOwAMDC5mPiH4vj39CjwBO3dnDI5mLBFqa3C4p0
         D/9mo9U1FbHp0GbKenjKqSw7ezXRg/Iy7ujL4cBV423Espsic/+C3yfAcEIwWjS6drrP
         spKRt1o2l/8JM3BTZAhbDK19a8EGg+yjh0D9NTj1GF3BAveWcKB9PrLWBMSMXC8tHz67
         h6YtOUz2fNZ5q8LZf4QgcXHj1LI6u6tMcNZNm4dFo+Yg+ByENBhTge1vCkmhL1WiDA0f
         Blkw==
X-Received: by 10.68.231.7 with SMTP id tc7mr24654110pbc.32.1405448210100;
        Tue, 15 Jul 2014 11:16:50 -0700 (PDT)
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)
Xref: news.gmane.org gmane.linux.lib.musl.general:5491 gmane.linux.distributions.alpine.devel:2077
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/5491>

On alpine, gpm 1.20.7 doesn't build completely, so I've been poking at it.
There were numerous cases of sys/select.h being omitted, but the biggest
issue I've hit so far is the use of SA_INTERRUPT in a call to sigaction();
the purpose is to break out of select() without it getting restarted.
musl does not define or support SA_INTERRUPT, as far as I can tell (I
seem to recall that musl forces SA_RESTART).

This is in src/prog/gpm-root.y, which is the source for the "gpm-root"
utility.

Any idea what to do about this?
I could build gpm without it, but (a) I'd like to see the whole mess
build, and (b) I'm not sure how to tell make that it can skip gpm-root.

As a temporary fix, I'm using this patch:
-#if defined(__GLIBC__)
-   __sigemptyset(&childaction.sa_mask);
-#else /* __GLIBC__ */
-   childaction.sa_mask=0;
-#endif /* __GLIBC__ */
+   sigemptyset(&childaction.sa_mask);
+#ifdef SA_INTERRUPT
    childaction.sa_flags=SA_INTERRUPT; /* need to break the select() call */
+#endif


Thanks,
Isaac Dunham