From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5534 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] implement issetugid(2) (v4) Date: Sat, 19 Jul 2014 21:45:16 -0400 Message-ID: <20140720014516.GJ17402@brightrain.aerifal.cx> References: <1405441807-5327-1-git-send-email-bcook@openbsd.org> <20140715201637.GI17402@brightrain.aerifal.cx> <20140717010830.GO17402@brightrain.aerifal.cx> <20140719200725.GC17402@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1405820737 16135 80.91.229.3 (20 Jul 2014 01:45:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Jul 2014 01:45:37 +0000 (UTC) Cc: beck@openbsd.org, Brent Cook To: musl@lists.openwall.com Original-X-From: musl-return-5539-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jul 20 03:45:30 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1X8gBu-0006SM-7u for gllmg-musl@plane.gmane.org; Sun, 20 Jul 2014 03:45:30 +0200 Original-Received: (qmail 5791 invoked by uid 550); 20 Jul 2014 01:45:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 5782 invoked from network); 20 Jul 2014 01:45:29 -0000 Content-Disposition: inline In-Reply-To: <20140719200725.GC17402@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:5534 Archived-At: On Sat, Jul 19, 2014 at 04:07:25PM -0400, Rich Felker wrote: > On Wed, Jul 16, 2014 at 09:33:11PM -0500, Brent Cook wrote: > > > My leaning so far is to include issetugid even if the glibc folks > > > don't want to, since there seems to be no remotely portable way to > > > achieve the same thing without it. The suggestion of using getauxval > > > is much more low-level and tied to particular implementations (ELF or > > > ELF-like ones with aux vector or which emulate it), and I don't think > > > it's a reliable approach for applications linked to musl (since they > > > might be running on a 2.4 kernel). So even if software has to have a > > > fallback for glibc systems, I'd prefer that it use a libc-provided > > > issetugid() on musl so that we can provide a reliable answer rather > > > than asking the caller to make assumptions about the system. > > > > OK, thanks for considering it. > > Based on the discussion so far, I'm going to commit it. Committed! Rich