From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Non-stub gettext API functions committed, ready for testing
Date: Mon, 28 Jul 2014 15:00:17 +0200 [thread overview]
Message-ID: <20140728130017.GK10402@port70.net> (raw)
In-Reply-To: <20140728101829.GJ10402@port70.net>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
* Szabolcs Nagy <nsz@port70.net> [2014-07-28 12:18:30 +0200]:
> the parser and eval code is about 2k now, i can try to do it
> without a separate parsing step (my approach requires a 100-200
> byte buffer to store the parsed expr now)
>
attached a simpler solution without separate parsing
(code is about 1.4k now, and it is more compatible
with gnu gettext)
[-- Attachment #2: pl.c --]
[-- Type: text/x-csrc, Size: 3698 bytes --]
#include <stdlib.h>
#include <ctype.h>
#include "pl.h"
/*
grammar:
Start = Expr ';'
Expr = Or | Or '?' Expr ':' Expr
Or = And | Or '||' And
And = Eq | And '&&' Eq
Eq = Rel | Eq '==' Rel | Eq '!=' Rel
Rel = Add | Rel '<=' Add | Rel '>=' Add | Rel '<' Add | Rel '>' Add
Add = Mul | Add '+' Mul | Add '-' Mul
Mul = Term | Mul '*' Term | Mul '/' decimal | Mul '%' decimal
Term = '(' Expr ')' | '!' Term | decimal | 'n'
internals:
recursive descent expression evaluator with stack depth limit.
eval* functions return the value of the subexpression and set
the current string pointer to the next non-space char.
*/
struct st {
const char *s;
unsigned long n;
int err;
};
static const char *skipspace(const char *s)
{
while (isspace(*s)) s++;
return s;
}
static unsigned long evalconst(struct st *st)
{
char *e;
unsigned long n;
n = strtoul(st->s, &e, 10);
if (!isdigit(*st->s) || e == st->s || n == -1)
st->err = 1;
st->s = skipspace(e);
return n;
}
static unsigned long evalexpr(struct st *st, int d);
static unsigned long evalterm(struct st *st, int d)
{
unsigned long a;
if (d <= 0) {
st->err = 1;
return 0;
}
st->s = skipspace(st->s);
if (*st->s == '!') {
st->s++;
return !evalterm(st, d-1);
}
if (*st->s == '(') {
st->s++;
a = evalexpr(st, d-1);
if (*st->s != ')') {
st->err = 1;
return 0;
}
st->s = skipspace(st->s + 1);
return a;
}
if (*st->s == 'n') {
st->s = skipspace(st->s + 1);
return st->n;
}
return evalconst(st);
}
static unsigned long evalmul(struct st *st, int d)
{
unsigned long b, a = evalterm(st, d-1);
int op;
for (;;) {
op = *st->s;
if (op != '*' && op != '/' && op != '%')
return a;
st->s++;
b = evalterm(st, d-1);
if (op == '*') {
a *= b;
} else if (!b) {
st->err = 1;
return 0;
} else if (op == '%') {
a %= b;
} else {
a /= b;
}
}
}
static unsigned long evaladd(struct st *st, int d)
{
unsigned long a = 0;
int add = 1;
for (;;) {
a += (add?1:-1) * evalmul(st, d-1);
if (*st->s != '+' && *st->s != '-')
return a;
add = *st->s == '+';
st->s++;
}
}
static unsigned long evalrel(struct st *st, int d)
{
unsigned long b, a = evaladd(st, d-1);
int less, eq;
for (;;) {
if (*st->s != '<' && *st->s != '>')
return a;
less = st->s[0] == '<';
eq = st->s[1] == '=';
st->s += 1 + eq;
b = evaladd(st, d-1);
a = (less ? a < b : a > b) || (eq && a == b);
}
}
static unsigned long evaleq(struct st *st, int d)
{
unsigned long a = evalrel(st, d-1);
int neg;
for (;;) {
if ((st->s[0] != '=' && st->s[0] != '!') || st->s[1] != '=')
return a;
neg = st->s[0] == '!';
st->s += 2;
a = evalrel(st, d-1) == a;
a ^= neg;
}
}
static unsigned long evaland(struct st *st, int d)
{
unsigned long a = evaleq(st, d-1);
for (;;) {
if (st->s[0] != '&' || st->s[1] != '&')
return a;
st->s += 2;
a = evaleq(st, d-1) && a;
}
}
static unsigned long evalor(struct st *st, int d)
{
unsigned long a = evaland(st, d-1);
for (;;) {
if (st->s[0] != '|' || st->s[1] != '|')
return a;
st->s += 2;
a = evaland(st, d-1) || a;
}
}
static unsigned long evalexpr(struct st *st, int d)
{
unsigned long a1, a2, a3;
if (d <= 0) {
st->err = 1;
return 0;
}
a1 = evalor(st, d-1);
if (*st->s != '?')
return a1;
st->s++;
a2 = evalexpr(st, d-1);
if (*st->s != ':') {
st->err = 1;
return 0;
}
st->s++;
a3 = evalexpr(st, d-1);
return a1 ? a2 : a3;
}
unsigned long eval(const char *s, size_t len, unsigned long n)
{
unsigned long a;
const char *e = s+len-1;
struct st st;
if (*e != ';')
return -1;
st.s = s;
st.n = n;
st.err = 0;
a = evalexpr(&st, 100);
if (st.err || st.s != e)
return -1;
return a;
}
next prev parent reply other threads:[~2014-07-28 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 8:46 Rich Felker
2014-07-27 10:06 ` Harald Becker
2014-07-27 14:14 ` Szabolcs Nagy
2014-07-27 16:49 ` Rich Felker
2014-07-27 17:23 ` Szabolcs Nagy
2014-07-27 17:36 ` Rich Felker
2014-07-27 17:51 ` Szabolcs Nagy
2014-07-27 18:00 ` Rich Felker
2014-07-28 10:18 ` Szabolcs Nagy
2014-07-28 13:00 ` Szabolcs Nagy [this message]
2014-07-28 14:01 ` Szabolcs Nagy
2014-07-28 16:27 ` Rich Felker
2014-07-29 13:49 ` Szabolcs Nagy
2014-07-27 10:19 ` Harald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728130017.GK10402@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).