From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Reviewing if_nameindex and getifaddrs patch
Date: Tue, 29 Jul 2014 20:55:44 -0400 [thread overview]
Message-ID: <20140730005543.GJ1674@brightrain.aerifal.cx> (raw)
In-Reply-To: <20140729144943.GI1674@brightrain.aerifal.cx>
On Tue, Jul 29, 2014 at 10:49:43AM -0400, Rich Felker wrote:
> On Mon, Jul 28, 2014 at 11:13:27AM +0300, Timo Teras wrote:
> > On Sun, 27 Jul 2014 20:49:06 -0400
> > Rich Felker <dalias@libc.org> wrote:
> >
> > > In regards to:
> > >
> > > http://git.alpinelinux.org/cgit/aports/plain/main/musl/1002-reimplement-if_nameindex-and-getifaddrs-using-netlin.patch?id=3227b4ad816f850f655b6f44dc497926cb2cdcd1
> >
> > Updated patch in the end.
>
> I can't get the patch to apply. Not sure whether email ate it or if
> there's an underlying problem.
Based on the version of this patch re-sent off-list, which I'm
attaching, I've reviewed it and fixed up a few remaining issues:
- Missing pthread_setcancelstate in if_nameindex.
- Possibly wrong errno from if_nameindex (needs to set ENOBUFS).
With these changes I'm committing it; we can make further improvements
later if needed. Perhaps getifaddrs should also avoid being
cancellable, but it's non-POSIX and thus this isn't really specified,
and the old one was already cancellable so there's no regression.
Thanks for working on this and being patient.
Rich
next prev parent reply other threads:[~2014-07-30 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 0:49 Rich Felker
2014-07-28 8:13 ` Timo Teras
2014-07-29 14:34 ` Rich Felker
2014-07-29 14:49 ` Rich Felker
2014-07-30 0:55 ` Rich Felker [this message]
2014-07-30 0:58 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730005543.GJ1674@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).