mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: reserved symbol violations
Date: Sat, 2 Aug 2014 12:37:43 -0400	[thread overview]
Message-ID: <20140802163743.GS1674@brightrain.aerifal.cx> (raw)
In-Reply-To: <1406996883.8274.181.camel@eris.loria.fr>

On Sat, Aug 02, 2014 at 06:28:03PM +0200, Jens Gustedt wrote:
> Hi,
>  by digging into the symbols that are dragged into a C11 thread
> executable I noticed that there are some hotspots that should perhaps
> be worth looking at. I attach a file that summarizes the findings.
> 
> One is simple, I'd change the reference to clock_gettime in
> __timedwait to __clock_gettime.

That's fine.

> One looks weird, though, lock_ptc.o It is only linked (via __synccall)
> if setrlimit or setxid are. But then it drags a whole bunch of pthread
> symbols in, which looks wrong to me. Also I think that this doesn't
> really capture the need, because the code is only active if both
> setrlimit *and* pthread_create are *used*.
> 
> So in the absence of either of it, __syncall shouldn't be linked. But
> I wouldn't know how to achieve this with weak symbols, I have to
> admit.

I have no idea how to make it get linked only if both are used, and I
suspect it's impossible. However, there's no namespace violation here;
setrlimit and set*id are from POSIX, not ISO C. So it's just excess
bloat.

Rich


  reply	other threads:[~2014-08-02 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-02 16:28 Jens Gustedt
2014-08-02 16:37 ` Rich Felker [this message]
2014-08-02 16:57   ` Jens Gustedt
2014-08-02 17:34     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140802163743.GS1674@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).