From: Rich Felker <dalias@libc.org>
To: 林冠儒 <g548462@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: fnmatch.h bug?
Date: Wed, 6 Aug 2014 06:23:17 -0400 [thread overview]
Message-ID: <20140806102317.GY1674@brightrain.aerifal.cx> (raw)
In-Reply-To: <CA+yBz7NTSDKFWxMEmPetttkT6D37AN0MMJrzocWQ3jV_z-ydpg@mail.gmail.com>
On Wed, Aug 06, 2014 at 06:03:33PM +0800, 林冠儒 wrote:
> I have do another experiment.
>
> musl-libc:
> i = fnmatch("\\","\\",0); // it returns 0 -> i=0
> i = fnmatch("\\","\\",FNM_NOESCAPE); // it also returns 0 -> i=0
>
> But I think this two lines of code should return different value because I
> set the FNM_NOESCAPE flag.
Per a strict reading of the current text of backslash is not special
when it appears at the end of the pattern string. See Austin Group
issue #806:
http://austingroupbugs.net/view.php?id=806
However, the way this was resolved (treating the final backslash as
unmatchable or as an error) does not match musl's current behavior, so
musl should be changed here.
> I also do same experiment in glibc:
> glibc:
> i = fnmatch("\\","\\",0); // it returns 1 -> i=1
> i = fnmatch("\\","\\",FNM_NOESCAPE); // it returns 0 -> i=0
>
>
> In another case:
> musl-libc:
> i = fnmatch("[1\\]","[1]",0); // it returns 1 -> i=1
> glibc:
> i = fnmatch("[1\\]","[1]",0); //it returns 0 -> i=0
>
> Because I DON'T set FNM_NOESCAPE flag, so glibc will escape ']' with two '\'
> And the return value should be 0 (match '[1]')
> Is it right ?
As nsz said, my interpretation of the requirements is that backslash
in a bracket expression is never special; it is an ordinary character.
This has been discussed before and nobody was able to prevent
convincing evidence to the contrary, but it's been a while since I
looked into the issue and I don't have the references handy.
> It would be very helpful if you email me back and tell me what's the problem
> Sorry ,my english is so poor.
No problem, you're communicating fine.
Rich
prev parent reply other threads:[~2014-08-06 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 3:01 林冠儒
2014-08-06 6:28 ` Szabolcs Nagy
2014-08-06 10:03 ` 林冠儒
2014-08-06 10:23 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806102317.GY1674@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=g548462@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).