From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: bug in pthread_cond_broadcast
Date: Tue, 12 Aug 2014 17:20:13 -0400 [thread overview]
Message-ID: <20140812212013.GD12888@brightrain.aerifal.cx> (raw)
In-Reply-To: <1407867539.15134.148.camel@eris.loria.fr>
On Tue, Aug 12, 2014 at 08:18:59PM +0200, Jens Gustedt wrote:
> Am Dienstag, den 12.08.2014, 13:19 -0400 schrieb Rich Felker:
> > Once broadcast returns (as observed by the thread which called
> > broadcast, or any thread that synchronizes with this thread after
> > broadcast returns), there are no waiters and it's valid to use a new
> > mutex with the cond var (or destroy it if it won't be used again).
>
> all the clients can only wakeup on holding their mutex, which in turn
> is only released by the main thread after it returns from the
> broadcast operation.
>
> so yes, the broadcast operation is synchronized with all other
> threads, that's the idea of this test
OK, thanks for clarifying. I'm still trying to understand where the
error in musl's accounting is happening -- I'd like to find a fix that
would be acceptable in the 1.0.x branch and make that fix before
possibly re-doing the cond var implementation (a fix which wouldn't be
suitable for backporting).
Rich
next prev parent reply other threads:[~2014-08-12 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 23:58 Jens Gustedt
2014-08-12 16:50 ` Szabolcs Nagy
2014-08-12 17:19 ` Rich Felker
2014-08-12 18:18 ` Jens Gustedt
2014-08-12 21:20 ` Rich Felker [this message]
2014-08-12 22:50 ` Jens Gustedt
2014-08-12 23:33 ` Rich Felker
2014-08-13 4:11 ` Rich Felker
2014-08-13 0:30 ` Rich Felker
2014-08-13 7:00 ` Jens Gustedt
2014-08-13 12:34 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812212013.GD12888@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).