mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Cond var cancellation issue raised on Austin Group tracker issue #609
Date: Thu, 21 Aug 2014 13:35:45 -0400	[thread overview]
Message-ID: <20140821173545.GA19756@brightrain.aerifal.cx> (raw)

Per note 0002350 on Austin Group tracker issue 609, there seems to be
some question as to whether cancellation can be acted upon in
pthread_cond_[timed]wait when the thread is formally already unblocked
by a signal/broadcast:

http://austingroupbugs.net/view.php?id=609#c2350

Presently, this situation can arise in musl, if after cancellation is
acted upon, the signaling thread wins the race to set the waiter's
state to SIGNALED rather than LEAVING.

If it's deemed important to fix (either from a standards conformance
standpoint, or just implementation quality), doing so should be easy:
we can have pthread_cond_timedwait call setjmp, and the cancellation
cleanup handler can call longjmp to abort cancellation if the state is
SIGNALED. This adds a very small amount of overhead (one setjmp call)
per wait.

In the process-shared case, we can't reliably determine whether a
signal occured here, so the process-shared case would just always
longjmp out of cancellation (formally, it would observing a spurious
wake just before cancellation would have happened).

Rich


                 reply	other threads:[~2014-08-21 17:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140821173545.GA19756@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).