From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5899
Path: news.gmane.org!not-for-mail
From: Rich Felker <dalias@libc.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Add login_tty
Date: Mon, 25 Aug 2014 18:43:33 -0400
Message-ID: <20140825224333.GX12888@brightrain.aerifal.cx>
References: <20140825185756.GA6077@euler>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1409006638 26787 80.91.229.3 (25 Aug 2014 22:43:58 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Mon, 25 Aug 2014 22:43:58 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-5905-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 26 00:43:49 2014
Return-path: <musl-return-5905-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-5905-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1XM2zK-00042h-Gt
	for gllmg-musl@plane.gmane.org; Tue, 26 Aug 2014 00:43:46 +0200
Original-Received: (qmail 7369 invoked by uid 550); 25 Aug 2014 22:43:45 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 7361 invoked from network); 25 Aug 2014 22:43:45 -0000
Content-Disposition: inline
In-Reply-To: <20140825185756.GA6077@euler>
User-Agent: Mutt/1.5.21 (2010-09-15)
Original-Sender: Rich Felker <dalias@aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:5899
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/5899>

On Mon, Aug 25, 2014 at 08:57:57PM +0200, Felix Janda wrote:
> Hi,
> 
> could "int login_tty(int fd)" be added? It is essentially the part of
> forkpty() executed by the forked child. (apart from closing the master)
> 
> For example, uim(-fep) uses it for a modified forkpty(). Some other
> programs might be pulling in the corresponding gnulib module.

I don't have any fundamental objection to this. It might be nice to
review the forkpty code for errors it should be checking and make
these improvements at the same time, though.

Rich