From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/5977 Path: news.gmane.org!not-for-mail From: Felix Janda Newsgroups: gmane.linux.lib.musl.general Subject: Re: Add login_tty Date: Fri, 29 Aug 2014 20:44:09 +0200 Message-ID: <20140829184409.GA30321@euler> References: <20140825185756.GA6077@euler> <20140825224333.GX12888@brightrain.aerifal.cx> <20140826165627.GA1208@euler> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1409337958 26407 80.91.229.3 (29 Aug 2014 18:45:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Aug 2014 18:45:58 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-5984-gllmg-musl=m.gmane.org@lists.openwall.com Fri Aug 29 20:45:47 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1XNRB4-0005MP-CY for gllmg-musl@plane.gmane.org; Fri, 29 Aug 2014 20:45:38 +0200 Original-Received: (qmail 11420 invoked by uid 550); 29 Aug 2014 18:45:37 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11412 invoked from network); 29 Aug 2014 18:45:37 -0000 X-Virus-Scanned: amavisd-new at posteo.de Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20140826165627.GA1208@euler> User-Agent: Mutt/1.5.22 (2013-10-16) Xref: news.gmane.org gmane.linux.lib.musl.general:5977 Archived-At: Felix Janda wrote: > Rich Felker wrote: > [..] > > I don't have any fundamental objection to this. It might be nice to > > review the forkpty code for errors it should be checking and make > > these improvements at the same time, though. > > Ok, attached a proposed patch. Any comments? login_tty() fails if and only if the ioctl fails. This is what I have read in online man pages of other implementations. It might be desirable to make forkpty() fail when login_tty() fails in the child. Felix