From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/6099
Path: news.gmane.org!not-for-mail
From: Felix Janda <felix.janda@posteo.de>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: Add login_tty
Date: Fri, 5 Sep 2014 20:52:55 +0200
Message-ID: <20140905185254.GA24471@euler>
References: <20140825185756.GA6077@euler>
 <20140825224333.GX12888@brightrain.aerifal.cx>
 <20140826165627.GA1208@euler>
 <20140904212159.GG10361@port70.net>
 <20140905172351.GA1528@euler>
 <20140905172906.GN23797@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1409943263 16324 80.91.229.3 (5 Sep 2014 18:54:23 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 5 Sep 2014 18:54:23 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-6112-gllmg-musl=m.gmane.org@lists.openwall.com Fri Sep 05 20:54:18 2014
Return-path: <musl-return-6112-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-6112-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1XPyeG-0003sJ-UK
	for gllmg-musl@plane.gmane.org; Fri, 05 Sep 2014 20:54:17 +0200
Original-Received: (qmail 14253 invoked by uid 550); 5 Sep 2014 18:54:16 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 14245 invoked from network); 5 Sep 2014 18:54:16 -0000
X-Virus-Scanned: amavisd-new at posteo.de
Mail-Followup-To: musl@lists.openwall.com
Content-Disposition: inline
In-Reply-To: <20140905172906.GN23797@brightrain.aerifal.cx>
User-Agent: Mutt/1.5.22 (2013-10-16)
Xref: news.gmane.org gmane.linux.lib.musl.general:6099
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/6099>

Rich Felker wrote:
> On Fri, Sep 05, 2014 at 07:23:52PM +0200, Felix Janda wrote:
[..]
> > The other possibility for dup2 to fail seems to be EINTR.
> > (We already know that fd can't be invalid.)
> > Should this also be checked?
> 
> Why would EINTR happen? dup2 does not involve any sleep much less
> interruptible sleep/blocking.

You're right. Only EBUSY, EBADF or EINVAL can happen.

Felix