From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 5/9] add the functions for mtx_t
Date: Sat, 6 Sep 2014 21:51:49 -0400 [thread overview]
Message-ID: <20140907015148.GZ23797@brightrain.aerifal.cx> (raw)
In-Reply-To: <0f3acdbceb88a357600611d64f7b5ed13ab3eced.1409524413.git.Jens.Gustedt@inria.fr>
On Mon, Sep 01, 2014 at 12:46:57AM +0200, Jens Gustedt wrote:
> diff --git a/src/thread/mtx_lock.c b/src/thread/mtx_lock.c
> new file mode 100644
> index 0000000..4d5d75e
> --- /dev/null
> +++ b/src/thread/mtx_lock.c
> @@ -0,0 +1,13 @@
> +#include "pthread_impl.h"
> +#include <threads.h>
> +
> +int mtx_lock(mtx_t *m)
> +{
> + if (m->_m_type == PTHREAD_MUTEX_NORMAL && !a_cas(&m->_m_lock, 0, EBUSY))
> + return thrd_success;
> + /* Calling mtx_timedlock with a null pointer is an
> + extension. Such a call is convenient, here, since it avoids
> + to repeat the case analysis that is already done for
> + mtx_timedlock. */
> + return mtx_timedlock(m, 0);
> +}
> diff --git a/src/thread/mtx_timedlock.c b/src/thread/mtx_timedlock.c
> new file mode 100644
> index 0000000..08359d8
> --- /dev/null
> +++ b/src/thread/mtx_timedlock.c
> @@ -0,0 +1,18 @@
> +#include <threads.h>
> +#include <errno.h>
> +
> +int __pthread_mutex_timedlock(mtx_t *restrict m, const struct timespec *restrict ts);
> +
> +int mtx_timedlock(mtx_t *restrict mutex, const struct timespec *restrict ts) {
> + int ret = __pthread_mutex_timedlock(mutex, ts);
> + switch (ret) {
> + /* May also return EINVAL or EAGAIN. EAGAIN is
> + specially tricky since C11 doesn't define how many recursive
> + calls can be done. (this *isn't* the maximum amount of nested
> + calls!) This implementation here deals this with a counter and
> + detects overflow, so this is definitively UB. */
I'm omitting this comment for now because it sems wrong. EINVAL is not
possible here, and I can't find any evidence that "too many recursive
locks" is UB, so since mtx_timedlock is required to report errors when
the operation can't be performed, I think thrd_error is just the
"right behavior". The spec should be more clear though.
> diff --git a/src/thread/mtx_trylock.c b/src/thread/mtx_trylock.c
> new file mode 100644
> index 0000000..4f55796
> --- /dev/null
> +++ b/src/thread/mtx_trylock.c
> @@ -0,0 +1,21 @@
> +#include "pthread_impl.h"
> +#include <threads.h>
> +
> +int __pthread_mutex_trylock(pthread_mutex_t *restrict m);
> +
> +int mtx_trylock(mtx_t *restrict m) {
> + if (m->_m_type == PTHREAD_MUTEX_NORMAL)
> + return (a_cas(&m->_m_lock, 0, EBUSY) & EBUSY) ? thrd_busy : thrd_success;
> +
> + int ret = __pthread_mutex_trylock(m);
> + switch (ret) {
> + /* In case of UB may also return EINVAL or EAGAIN. EAGAIN is
> + specially tricky since C11 doesn't define how many recursive
> + calls can be done. (this *isn't* the maximum amount of nested
> + calls!) This implementation here deals this with a counter and
> + detects overflow, so this is definitively UB. */
Likewise here. One could even argue thrd_busy is more appropriate
here, but for consistency it should probably be thrd_error too.
> diff --git a/src/thread/mtx_unlock.c b/src/thread/mtx_unlock.c
> new file mode 100644
> index 0000000..e673cd5
> --- /dev/null
> +++ b/src/thread/mtx_unlock.c
> @@ -0,0 +1,9 @@
> +#include <threads.h>
> +
> +int __pthread_mutex_unlock(mtx_t *);
> +
> +int (mtx_unlock)(mtx_t *mtx) {
> + int ret = __pthread_mutex_unlock(mtx);
> + /* In case of UB may also return EPERM. */
> + return ret ? thrd_error : thrd_success;
> +}
We had discussed trimming this down at some point (there is no error
that's not UB) to make it a tail call, so I'll try to do that now.
Rich
next prev parent reply other threads:[~2014-09-07 1:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 22:45 [PATCH 0/9] C thread patch series, v. 8.6 and 9.7 Jens Gustedt
2014-08-31 22:45 ` [PATCH 1/9] interface additions for the C thread implementation Jens Gustedt
2014-09-07 0:21 ` Rich Felker
2014-09-07 9:13 ` Jens Gustedt
2014-09-07 10:05 ` Alexander Monakov
2014-09-07 11:16 ` Jens Gustedt
2014-09-07 11:31 ` Alexander Monakov
2014-09-07 11:32 ` Rich Felker
2014-09-07 14:45 ` Jens Gustedt
2014-09-07 15:16 ` Rich Felker
2014-09-07 16:51 ` Jens Gustedt
2014-09-07 16:55 ` Rich Felker
2014-09-07 1:19 ` Rich Felker
2014-08-31 22:46 ` [PATCH 2/9] additions to src/time and some implied minor changes here and there Jens Gustedt
2014-09-06 17:44 ` Rich Felker
2014-08-31 22:46 ` [PATCH 3/9] use weak symbols for the POSIX functions that will be used by C threads Jens Gustedt
2014-09-06 18:52 ` Rich Felker
2014-08-31 22:46 ` [PATCH 4/9] add the functions for tss_t and once_flag Jens Gustedt
2014-08-31 22:46 ` [PATCH 5/9] add the functions for mtx_t Jens Gustedt
2014-09-07 1:51 ` Rich Felker [this message]
2014-09-07 1:54 ` Rich Felker
2014-08-31 22:47 ` [PATCH 6/9] add the functions for cnd_t Jens Gustedt
2014-08-31 22:47 ` [PATCH 7/9] add the thrd_xxxxxx functions Jens Gustedt
2014-09-07 14:24 ` Rich Felker
2014-09-07 14:52 ` Jens Gustedt
2014-09-07 15:17 ` Rich Felker
2014-08-31 22:47 ` [PATCH 8/9] separate pthread_create and pthread_exit in two different TU Jens Gustedt
2014-08-31 22:48 ` [PATCH 9/9] Separate pthread_create and thrd_create Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907015148.GZ23797@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).