mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: wrong behaviour of 'strverscmp'
Date: Mon, 13 Oct 2014 18:20:51 -0400	[thread overview]
Message-ID: <20141013222051.GI32028@brightrain.aerifal.cx> (raw)
In-Reply-To: <543B5BE2.6020104@i-soft.com.cn>

On Mon, Oct 13, 2014 at 12:58:10PM +0800, 黄建忠 wrote:
> Hi,
> 
> When I try to run some testcases, I found 'strverscmp' do not work like
> expected.
> 
> According to man page, 'Thus, the ordering is 000, 00, 01, 010, 09, 0,
> 1, 9, 10.'.
> 
> So the return value of strverscmp('000', '00) should less than zero, but
> musl return '0'-0(*l - *r), that is 48.

Confirmed that musl's strverscmp mismatches your expectations. Myself
and others think the expected behavior is ridiculous, but it's the
documented behavior and it's not very useful to provide an
implementation of a nonstandard function that doesn't match the one
present on systems that defined it, so this should be changed.

Of course we cannot use code from gnulib, though. I'll put fixing this
on the agenda and hopefully we can get it in the next release after
the upcoming 1.1.5 release. Thanks for the report.

Rich


      reply	other threads:[~2014-10-13 22:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13  4:58 黄建忠
2014-10-13 22:20 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013222051.GI32028@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).