From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: regcomp regression?
Date: Thu, 16 Oct 2014 03:12:10 +0200 [thread overview]
Message-ID: <20141016011210.GA3118@port70.net> (raw)
In-Reply-To: <543EE0A5.2000905@sholland.net>
* Samuel Holland <samuel@sholland.net> [2014-10-15 16:01:25 -0500]:
> I've been rebuilding packages after the 1.1.5 release, and it's caused
> some (apparent) regressions. file no longer compiles as it is unable to
> parse one of its magic files. The offending regex is (windows, line 163)
>
> \\`(\r\n|;|[[]|\xFF\xFE)
>
> It's testing for the BOM at the beginning of an INI/INF file. I
> understand the regex rewrite removed[1] the ability to match arbitrary
> bytes (even with the C locale) because it was broken; is this something
> you plan to add back? Or is the application wrong? If so, what
> workaround do you suggest?
this was a bug in file (in theory we could provide such extension, but
it's non-trivial and applications should not rely on it: posix re is not
usable for binary data)
there is upstream fix:
http://bugs.gw.com/view.php?id=383
> The m4 testsuite also now fails tests 109 and 121; this seems to be
> caused by the same change.
>
> [1] http://git.musl-libc.org/cgit/musl/commit?id=ec1aed0a144b3e00e16eeb142c9d13362d6048e7
>
this commit only made the bug more visible (fail at regex parse time
instead of building a nonsense state machine in case of invalid
characters)
i didnt know about m4 issues, are you talking about
http://git.savannah.gnu.org/gitweb/?p=m4.git;a=blob;f=tests/testsuite.at
?
next prev parent reply other threads:[~2014-10-16 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 21:01 Samuel Holland
2014-10-16 1:03 ` Rich Felker
2014-10-16 1:12 ` Szabolcs Nagy [this message]
2014-10-16 1:43 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016011210.GA3118@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).