From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/6337 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: regcomp regression? Date: Thu, 16 Oct 2014 03:12:10 +0200 Message-ID: <20141016011210.GA3118@port70.net> References: <543EE0A5.2000905@sholland.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1413421951 8751 80.91.229.3 (16 Oct 2014 01:12:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2014 01:12:31 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-6350-gllmg-musl=m.gmane.org@lists.openwall.com Thu Oct 16 03:12:27 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1XeZc7-0007sE-4H for gllmg-musl@plane.gmane.org; Thu, 16 Oct 2014 03:12:23 +0200 Original-Received: (qmail 14018 invoked by uid 550); 16 Oct 2014 01:12:22 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 14007 invoked from network); 16 Oct 2014 01:12:22 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <543EE0A5.2000905@sholland.net> User-Agent: Mutt/1.5.23 (2014-03-12) Xref: news.gmane.org gmane.linux.lib.musl.general:6337 Archived-At: * Samuel Holland [2014-10-15 16:01:25 -0500]: > I've been rebuilding packages after the 1.1.5 release, and it's caused > some (apparent) regressions. file no longer compiles as it is unable to > parse one of its magic files. The offending regex is (windows, line 163) > > \\`(\r\n|;|[[]|\xFF\xFE) > > It's testing for the BOM at the beginning of an INI/INF file. I > understand the regex rewrite removed[1] the ability to match arbitrary > bytes (even with the C locale) because it was broken; is this something > you plan to add back? Or is the application wrong? If so, what > workaround do you suggest? this was a bug in file (in theory we could provide such extension, but it's non-trivial and applications should not rely on it: posix re is not usable for binary data) there is upstream fix: http://bugs.gw.com/view.php?id=383 > The m4 testsuite also now fails tests 109 and 121; this seems to be > caused by the same change. > > [1] http://git.musl-libc.org/cgit/musl/commit?id=ec1aed0a144b3e00e16eeb142c9d13362d6048e7 > this commit only made the bug more visible (fail at regex parse time instead of building a nonsense state machine in case of invalid characters) i didnt know about m4 issues, are you talking about http://git.savannah.gnu.org/gitweb/?p=m4.git;a=blob;f=tests/testsuite.at ?