From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Add stdatomic.h for clang>=3.1 and gcc>=4.1
Date: Sat, 22 Nov 2014 21:42:59 -0500 [thread overview]
Message-ID: <20141123024259.GH29621@brightrain.aerifal.cx> (raw)
In-Reply-To: <e4297aac.dNq.dMV.1h.cxuw4R@mailjet.com>
On Sun, Nov 23, 2014 at 02:47:12AM +0100, Joakim Sindholt wrote:
> > > > > > I have changed it to be an atomic_bool in a struct as both GCC and Clang
> > > > > > has it in a struct. Presumably to separate it from the generic _Atomic
> > > > > > stuff.
> > > > >
> > > > > Again, since we want to have ABI compatibility, it is not your choice
> > > > > to make. You'd simply have to stick to the choice that gcc made. So
> > > > > you have to copy the declaration of the struct, including all the
> > > > > ifdef fuzz.
> > > >
> > > > I'd have to look at it again, but IIRC only one case of the #ifdef
> > > > mess was actually possible. The others were for hypothetical archs
> > > > without real atomics which we can't support anyway.
> > >
> > > We should have it as a struct, if the implementations have it like
> > > that, I think:
> > >
> > > - It should have same alignment properties for ABI compatibility.
> > > - It should lead to the same typename when included in C++.
> >
> > Yes.
> >
> > > The ifdef is a single one to switch between _Bool or unsigned char or
> > > so.
> >
> > Yes, but I think the #ifdef always comes out one way anyway, though I
> > don't remember which one and don't have the file in front of me.
>
> GCC 4.9:
>
> typedef _Atomic struct
> {
> #if __GCC_ATOMIC_TEST_AND_SET_TRUEVAL == 1
> _Bool __val;
> #else
> unsigned char __val;
> #endif
> } atomic_flag;
>
> Clang 3.6:
>
> #ifdef __cplusplus
> typedef _Atomic(bool) atomic_bool;
> #else
> typedef _Atomic(_Bool) atomic_bool;
> #endif
>
> typedef struct atomic_flag { atomic_bool _Value; } atomic_flag;
So yes, only the true case of the #if is needed, and that's what clang
implements. The other is for hypothetical archs which lack the ability
to CAS 0 and 1 into an object of type _Bool -- for example, perhaps
they can do a lock-free boolean test-and-set, but only with values 0
and -1, whereas _Bool needs to store 1 for true. This is just a guess
what the GCC folks might have had in mind, but in any case, it doesn't
matter, since we assume a full CAS (and require a kernel that emulates
one if the hardware does not have one).
Rich
next prev parent reply other threads:[~2014-11-23 2:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 12:53 Joakim Sindholt
2014-11-09 17:11 ` Jens Gustedt
2014-11-22 20:52 ` Joakim Sindholt
2014-11-22 23:09 ` Jens Gustedt
2014-11-22 23:30 ` Rich Felker
2014-11-23 1:31 ` Jens Gustedt
2014-11-23 1:43 ` Rich Felker
2014-11-23 1:47 ` Joakim Sindholt
2014-11-23 2:42 ` Rich Felker [this message]
2014-11-23 9:43 ` Jens Gustedt
2014-11-23 15:21 ` Rich Felker
2014-11-23 16:29 ` Jens Gustedt
2014-11-23 16:38 ` Rich Felker
2014-11-23 17:05 ` Jens Gustedt
2014-11-23 17:29 ` stephen Turner
2014-11-23 19:38 ` Rich Felker
2014-11-23 8:49 ` Jens Gustedt
2014-11-23 15:06 ` Rich Felker
2014-11-23 16:18 ` Jens Gustedt
2014-11-23 16:37 ` Rich Felker
2014-11-23 18:01 ` Jens Gustedt
2014-11-23 19:39 ` Rich Felker
2014-11-23 23:30 ` Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123024259.GH29621@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).