From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/6744 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Add login_tty Date: Sat, 20 Dec 2014 20:15:42 -0500 Message-ID: <20141221011542.GH4574@brightrain.aerifal.cx> References: <20141101222729.GB5949@euler> <20141101224325.GM22465@brightrain.aerifal.cx> <20141101225643.GA8817@euler> <20141102000944.GN22465@brightrain.aerifal.cx> <20141102141912.GA3637@euler> <20141102162841.GP22465@brightrain.aerifal.cx> <20141102185638.GA21712@euler> <20141102222818.GR22465@brightrain.aerifal.cx> <20141103182954.GA4423@euler> <20141221005821.GG4574@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1419124563 18988 80.91.229.3 (21 Dec 2014 01:16:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Dec 2014 01:16:03 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-6757-gllmg-musl=m.gmane.org@lists.openwall.com Sun Dec 21 02:15:56 2014 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Y2V7k-0000Ex-3p for gllmg-musl@m.gmane.org; Sun, 21 Dec 2014 02:15:56 +0100 Original-Received: (qmail 28097 invoked by uid 550); 21 Dec 2014 01:15:54 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 28089 invoked from network); 21 Dec 2014 01:15:54 -0000 Content-Disposition: inline In-Reply-To: <20141221005821.GG4574@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:6744 Archived-At: On Sat, Dec 20, 2014 at 07:58:21PM -0500, Rich Felker wrote: > On Mon, Nov 03, 2014 at 07:29:54PM +0100, Felix Janda wrote: > > Thanks for the review. Below a new version. > > Sorry I didn't get around to reviewing this right away. I just went ahead and committed login_tty since it's been pending so long. Refactoring forkpty in terms of it and making the other improvements to forkpty is still pending. I'll see if I can get something committed based on your work so far if you don't come up with something first. Thanks for all the work on this and your patience! Rich