From: Solar Designer <solar@openwall.com>
To: musl@lists.openwall.com
Subject: Re: isatty false positives and device state clobbering
Date: Sat, 31 Jan 2015 06:45:32 +0300 [thread overview]
Message-ID: <20150131034532.GA22669@openwall.com> (raw)
In-Reply-To: <20150131032953.GA23935@brightrain.aerifal.cx>
On Fri, Jan 30, 2015 at 10:29:53PM -0500, Rich Felker wrote:
> As can be seen by strace, the TCGETS ioctl used by
> isatty/fdopen/__stdout_write to determine whether a file descriptor is
> a terminal is aliased by the SNDCTL_TMR_TIMEBASE ioctl for OSS sound
> devices.
FWIW, I think I was the one to implement this reporting in strace:
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/strace/Attic/strace-20020608-owl-ioctl.diff?rev=1.1;content-type=text%2Fx-cvsweb-markup
(and this was later upstreamed), specifically because of the historical
mistake you describe.
IIRC, strace would say simply SNDCTL_TMR_TIMEBASE before this fix, even
though in most programs TCGETS was meant.
It's nice that you're trying to deal with another aspect of this issue
now... but not so nice that it exists in the first place.
Alexander
next prev parent reply other threads:[~2015-01-31 3:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 3:29 Rich Felker
2015-01-31 3:45 ` Solar Designer [this message]
2015-01-31 4:01 ` Rich Felker
2015-01-31 15:20 ` M Farkas-Dyck
2015-01-31 17:33 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131034532.GA22669@openwall.com \
--to=solar@openwall.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).