mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: x86[_64] memset and rep stos
Date: Wed, 25 Feb 2015 01:12:04 -0500	[thread overview]
Message-ID: <20150225061204.GA25485@brightrain.aerifal.cx> (raw)

Doing some timings on the new proposed memset code, I found it was
pathologically slow on my Atom D510 (32-bit) when reaching sizes
around 2k - 16k. Like 4x slower than the old code. Apparently the
issue is that the work being done to align the destination mod 4
misaligns it mod higher powers of two, and "rep stos" performs
pathologically bad when it's not cache-line-aligned, or something like
that. On my faster 64-bit system alignment mod 16 also seems to make a
difference, but less - it's 1.5x slower misaligned mod 16.

I also found that on the 32-bit Atom, there seems to be a huge jump in
speed at size 1024 -- sizes just below 1024 are roughly 2x slower.
Since it otherwise doesn't make a measurable difference, it seems
preferable _not_ to try to reduce the length of the rep stos to avoid
writing the same bytes multiple times but simply use the max allowable
length.

Combined with the first issue, it seems we should "round up to a
multiple of 16" rather than "add 16 then round down to a multiple of
16". Not only does this avoid reducing the length of the rep stos; it
also preserves any higher-than-16 alignment that might be preexisting,
in case even higher alignments are faster.

Rich


             reply	other threads:[~2015-02-25  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  6:12 Rich Felker [this message]
2015-02-25  7:54 ` 邓尧
2015-02-25  9:20   ` Szabolcs Nagy
2015-02-25 17:26     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225061204.GA25485@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).