mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: musl-gcc wrapper patch
Date: Wed, 11 Mar 2015 18:19:47 -0400	[thread overview]
Message-ID: <20150311221947.GH23507@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150311213208.GS16260@port70.net>

On Wed, Mar 11, 2015 at 10:32:08PM +0100, Szabolcs Nagy wrote:
> i assume the most common expectation is that the installed
> musl-gcc tool uses the same compiler as the musl build was
> using
> 
> at least this is what i would want for cross compilation
> 
> i guess this breaks if relative path or multiple words were
> used (cc with args) in $(CC)
> 
> comments?
> [...]
>  tools/musl-gcc: config.mak
> -	printf '#!/bin/sh\nexec "$${REALGCC:-gcc}" "$$@" -specs "%s/musl-gcc.specs"\n' "$(libdir)" > $@
> +	printf '#!/bin/sh\nexec "$${REALGCC:-%s}" "$$@" -specs "%s/musl-gcc.specs"\n' "$(CC)" "$(libdir)" > $@
>  	chmod +x $@

Since $CC can contain multiple shell words (e.g. a -m32 or similar)
perhaps we should remove the double-quotes around the expansion of
$REALGCC? Unfortunately this makes for a trade-off between supporting
'standard' usage of $CC and supporting pathnames containing
whitespace. Any opinions on the matter? Any ways to avoid the
tradeoff? Overall I'm in favor of this change anyway but I'd like to
avoid having any negative impact.

Rich


      reply	other threads:[~2015-03-11 22:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 21:32 Szabolcs Nagy
2015-03-11 22:19 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311221947.GH23507@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).