From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Explicit casts in ctype.h suppress compiler warnings
Date: Fri, 17 Apr 2015 12:52:38 -0400 [thread overview]
Message-ID: <20150417165238.GA6817@brightrain.aerifal.cx> (raw)
In-Reply-To: <1429289394.7038.3.camel@inria.fr>
On Fri, Apr 17, 2015 at 06:49:54PM +0200, Jens Gustedt wrote:
> Am Freitag, den 17.04.2015, 13:59 +0300 schrieb Alexander Monakov:
> > For the following erroneous source code:
> >
> > #include <ctype.h>
> > int f(char *c)
> > {
> > return isdigit(c) || isspace(c);
> > }
> >
> > GCC warns only for passing a pointer to isspace; isdigit is implemented as a
> > macro that casts its argument to unsigned, and the warning is suppresed
> > because the origin of the cast is in a system header. Since isspace is
> > implemented with a static inline helper function, there is a warning. With
> > glibc headers, no warning is issued in either case for a similar reason.
>
> I generally think that casts are a bad idea, anyhow, and should only
> be used where it must be done, that is basically for pointer to
> integer conversion (and back). Code like this
>
> #define isdigit(a) (((unsigned)(a)-'0') < 10)
>
> can easily be replaced by
>
> #define isdigit(a) (((unsigned const){a}-'0') < 10)
>
> to change the explicit conversion to an implicit one in the
> initializer of the compound literal. Then, any compiler would have to
> diagnose if "a" would be a pointer.
In another place (math.h) I removed this type of compound literal
usage because it was incompatible with C++, but the macros are
suppressed in C++ anyway. Still they might break -pedantic with
-std=c89. I do like this approach best in principle if it works
though, because the rules for when an error occurs are basically the
same as the rules for a real function.
Rich
next prev parent reply other threads:[~2015-04-17 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 10:59 Alexander Monakov
2015-04-17 16:49 ` Jens Gustedt
2015-04-17 16:52 ` Rich Felker [this message]
2015-04-17 18:24 ` Alexander Monakov
2015-04-17 18:35 ` Szabolcs Nagy
2015-04-17 19:43 ` Szabolcs Nagy
2015-04-17 20:21 ` Rich Felker
2015-04-17 20:32 ` Szabolcs Nagy
2015-04-17 20:34 ` Jens Gustedt
2015-04-17 21:36 ` Rich Felker
2015-04-18 2:03 ` Morten Welinder
2015-04-17 19:33 ` William Ahern
2015-04-17 16:50 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417165238.GA6817@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).