From: William Ahern <william@25thandClement.com>
To: musl@lists.openwall.com
Subject: Re: Explicit casts in ctype.h suppress compiler warnings
Date: Fri, 17 Apr 2015 12:33:20 -0700 [thread overview]
Message-ID: <20150417193320.GA11349@wilbur.25thandClement.com> (raw)
In-Reply-To: <20150417165238.GA6817@brightrain.aerifal.cx>
On Fri, Apr 17, 2015 at 12:52:38PM -0400, Rich Felker wrote:
> On Fri, Apr 17, 2015 at 06:49:54PM +0200, Jens Gustedt wrote:
<snip>
> > I generally think that casts are a bad idea, anyhow, and should only
> > be used where it must be done, that is basically for pointer to
> > integer conversion (and back). Code like this
> >
> > #define isdigit(a) (((unsigned)(a)-'0') < 10)
> >
> > can easily be replaced by
> >
> > #define isdigit(a) (((unsigned const){a}-'0') < 10)
> >
> > to change the explicit conversion to an implicit one in the
> > initializer of the compound literal. Then, any compiler would have to
> > diagnose if "a" would be a pointer.
>
> In another place (math.h) I removed this type of compound literal
> usage because it was incompatible with C++, but the macros are
> suppressed in C++ anyway. Still they might break -pedantic with
> -std=c89. I do like this approach best in principle if it works
> though, because the rules for when an error occurs are basically the
> same as the rules for a real function.
I think C++11 brace initialization
int { 42 }
works nearly identically to C99 compound literal definition
(int){ 42 }
The big difference is that the lifetime of C++ temporaries have expression
scope, whereas compound literals have block scope. But that's irrelevant
where the values will be copied and no pointer is derived.*
A simple macro could be used to select the syntax. However, I don't think
something like `unsigned char { 42 }' will work. The type name needs to be a
single identifier, so a typedef would be needed: u_char { 42 }.
* Unfortunately, by default g++ accepts C99-style compound literals, but for
whatever reason gives them expression-scoped lifetimes as-if they were C++
temporaries. This gave me and some other people grief when when using
pointers to compound literals, either explicitly or implicitly through
array-to-pointer decay). See Bug #53220. Everything seemed to work when
compiled as C++, unless you were fortunate enough to get a crash near the
offending code. More recent versions of g++ now at least warn when a pointer
is derived from a compound literal.
I think clang++ has the same behavior.
next prev parent reply other threads:[~2015-04-17 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 10:59 Alexander Monakov
2015-04-17 16:49 ` Jens Gustedt
2015-04-17 16:52 ` Rich Felker
2015-04-17 18:24 ` Alexander Monakov
2015-04-17 18:35 ` Szabolcs Nagy
2015-04-17 19:43 ` Szabolcs Nagy
2015-04-17 20:21 ` Rich Felker
2015-04-17 20:32 ` Szabolcs Nagy
2015-04-17 20:34 ` Jens Gustedt
2015-04-17 21:36 ` Rich Felker
2015-04-18 2:03 ` Morten Welinder
2015-04-17 19:33 ` William Ahern [this message]
2015-04-17 16:50 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417193320.GA11349@wilbur.25thandClement.com \
--to=william@25thandclement.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).