From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7414 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Explicit casts in ctype.h suppress compiler warnings Date: Fri, 17 Apr 2015 17:36:02 -0400 Message-ID: <20150417213602.GF6817@brightrain.aerifal.cx> References: <1429289394.7038.3.camel@inria.fr> <20150417165238.GA6817@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1429306577 18355 80.91.229.3 (17 Apr 2015 21:36:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 21:36:17 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7427-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 17 23:36:17 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YjDvs-0007DO-E3 for gllmg-musl@m.gmane.org; Fri, 17 Apr 2015 23:36:16 +0200 Original-Received: (qmail 29698 invoked by uid 550); 17 Apr 2015 21:36:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 28651 invoked from network); 17 Apr 2015 21:36:14 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7414 Archived-At: On Fri, Apr 17, 2015 at 09:24:09PM +0300, Alexander Monakov wrote: > > Do you have an idea in mind for how we could achieve that? I suspect > > the macros are still better optimizable than the inline function > > approach, so I'd lean towards doing a macro that avoids evaluating c > > and just checks its type, which would involve using ?: I think. > > I admit I was thinking of doing isspace-style inlines everywhere, but thanks > to your suggestion I was able to come up with this: > > static __inline void __is_int(int a) {} > #define isdigit(a) (__is_int(0?(a):0), ((unsigned)(a)-'0') < 10) This still depends on the inline function getting honored, and puts extra crap in the debug output. Instead, how about: #define isdigit(a) (0 ? (isdigit)(a) : ((unsigned)(a)-'0') < 10) Rich