From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: ppc fix
Date: Sat, 18 Apr 2015 18:28:53 -0400 [thread overview]
Message-ID: <20150418222853.GK6817@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAK4o1Wy02JWJYh9U_AD7_dVuySzTXznD-C-tdM5hPC-9mu6v4w@mail.gmail.com>
On Sat, Apr 18, 2015 at 11:10:17PM +0100, Justin Cormack wrote:
> Starting to look at powerppc64, can you apply the following patch to
> fix the detection macro, it is __PPC64__ not __PPC64. Attached as well
> in case MTA mangles it.
>
> Justin
>
>
> diff --git a/arch/powerpc/bits/syscall.h b/arch/powerpc/bits/syscall.h
> index acd825a..a3c2c90 100644
> --- a/arch/powerpc/bits/syscall.h
> +++ b/arch/powerpc/bits/syscall.h
> @@ -194,7 +194,7 @@
> #define __NR_vfork 189
> #define __NR_ugetrlimit 190
> #define __NR_readahead 191
> -#if !defined(__PPC64) || defined(__ABI32)
> +#if !defined(__PPC64__) || defined(__ABI32)
This header is for the 32-bit powerpc arch; I'm not sure why these
#ifdefs ever got committed to begin with. As part of the arch/bits
deduplication effort (coming up) it may make sense to use a unified
source file for powerpc and powerpc64, but it would probably be
processed by the build system rather than having installed #ifdefs.
Rich
prev parent reply other threads:[~2015-04-18 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 22:10 Justin Cormack
2015-04-18 22:28 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418222853.GK6817@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).