From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7494 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: Static analysis results Date: Thu, 23 Apr 2015 20:08:04 +0200 Message-ID: <20150423180804.GC17440@port70.net> References: <20150423164150.GG17573@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1429812506 19425 80.91.229.3 (23 Apr 2015 18:08:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Apr 2015 18:08:26 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7507-gllmg-musl=m.gmane.org@lists.openwall.com Thu Apr 23 20:08:24 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YlLXv-0004dc-2j for gllmg-musl@m.gmane.org; Thu, 23 Apr 2015 20:08:19 +0200 Original-Received: (qmail 11845 invoked by uid 550); 23 Apr 2015 18:08:17 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11827 invoked from network); 23 Apr 2015 18:08:16 -0000 Mail-Followup-To: musl@lists.openwall.com Content-Disposition: inline In-Reply-To: <20150423164150.GG17573@brightrain.aerifal.cx> User-Agent: Mutt/1.5.23 (2014-03-12) Xref: news.gmane.org gmane.linux.lib.musl.general:7494 Archived-At: * Rich Felker [2015-04-23 12:41:51 -0400]: > Aside from regcomp which I want to ask nsz on before committing > anything, I believe these are all fixed now by the following commits: > > > regcomp.c:2848 > > condition 'stack != NULL' cannot hold > > [open but not a bug] > stack is always non-zero there all the NULL checks in the error path are unnecessary as far as i can see