From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fmtmsg: verify that label is in the correct format.
Date: Sat, 25 Apr 2015 13:14:17 -0400 [thread overview]
Message-ID: <20150425171417.GU17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <1429978535-1977-1-git-send-email-ibid.ag@gmail.com>
On Sat, Apr 25, 2015 at 09:15:35AM -0700, Isaac Dunham wrote:
> According to POSIX, "the format is two fields separated by a colon.
> The first field is up to 10 bytes, the second is up to 14 bytes."
> The original implementation assumed that the application provided
> a valid label.
Is there a particular problem you're trying to solve? It's not clear
to me from the text (which seems under-specified) whether there's an
obligation to diagnose errors here, or whether failure to meet the
contract for the format of the inputs yields unspecified or undefined
behavior. I'm not necessarily opposed to the change but I'd like to
understand this better so that it would be well-motivated.
Rich
next prev parent reply other threads:[~2015-04-25 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 16:15 Isaac Dunham
2015-04-25 17:14 ` Rich Felker [this message]
2015-04-25 18:19 ` Isaac Dunham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425171417.GU17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).