From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Pending patches & other changes
Date: Tue, 28 Apr 2015 09:46:47 -0400 [thread overview]
Message-ID: <20150428134647.GN17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150428094320.GA11625@port70.net>
On Tue, Apr 28, 2015 at 11:43:21AM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@libc.org> [2015-04-27 23:48:20 -0400]:
> > Here is a list of patches I'm aware of that have been sent to the list
> > that I haven't yet applied or rejected:
> >
> > [PATCH] generate debug_frame info for __syscall_cp_asm (i386) so gdb can get backtrace
> > [PATCH] fmtmsg: verify that label is in the correct format.
> > [PATCH] replace 'hlt' by 'ud2' in i386/x32/x86_64 a_crash implementations
> > [PATCH] conforming strverscmp() implementation
> >
> > There are also a few patches from nsz on the radar:
> >
> > http://port70.net/~nsz/musl/0001-add-IPTOS_CLASS_-macros-to-netinet-ip.h.patch
> > http://port70.net/~nsz/musl/0001-complex-fix-ctanh-0-i-nan-and-ctanh-0-i-inf.patch
> > http://port70.net/~nsz/musl/0001-inet_pton-clean-up.patch
> >
> > and the BRE extensions that are still under discussion, and possibly
> > some cleanup of some always-false null checks in the failure path of
> > regcomp.
> >
> > There's also the idea of changing getlogin[_r] to probe the actual
> > controlling terminal and its owner to get the "logged in user" rather
> > than just using $LOGNAME. I've done some work on this but it's not
> > done and not clean for commit.
> >
> > Anything else I'm missing? Most of this probably won't go in the
> > release but I at least want to make sure we have a good inventory of
> > what's still pending.
> >
>
> i forgot to do this one in elf.h:
>
> -#define SHF_EXCLUDE (1 << 31)
> +#define SHF_EXCLUDE (1U << 31)
>
> (there is no other invalid <<31)
This was discussed quite a bit on libc-alpha (glibc list) and it seems
the consensus there is that changing the type to unsigned is
potentially dangerous and it would be better to use (-0x7fffffff-1) or
perhaps ((1<<30) * -2) if it's more clear. What do you think?
Rich
next prev parent reply other threads:[~2015-04-28 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 3:48 Rich Felker
2015-04-28 9:43 ` Szabolcs Nagy
2015-04-28 13:46 ` Rich Felker [this message]
2015-04-28 13:55 ` Szabolcs Nagy
2015-05-01 17:42 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428134647.GN17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).