From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7542 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Pending patches & other changes Date: Tue, 28 Apr 2015 09:46:47 -0400 Message-ID: <20150428134647.GN17573@brightrain.aerifal.cx> References: <20150428034820.GA28803@brightrain.aerifal.cx> <20150428094320.GA11625@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1430228826 9154 80.91.229.3 (28 Apr 2015 13:47:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 28 Apr 2015 13:47:06 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7555-gllmg-musl=m.gmane.org@lists.openwall.com Tue Apr 28 15:47:05 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Yn5qn-00028s-9t for gllmg-musl@m.gmane.org; Tue, 28 Apr 2015 15:47:01 +0200 Original-Received: (qmail 26436 invoked by uid 550); 28 Apr 2015 13:46:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 26417 invoked from network); 28 Apr 2015 13:46:59 -0000 Content-Disposition: inline In-Reply-To: <20150428094320.GA11625@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7542 Archived-At: On Tue, Apr 28, 2015 at 11:43:21AM +0200, Szabolcs Nagy wrote: > * Rich Felker [2015-04-27 23:48:20 -0400]: > > Here is a list of patches I'm aware of that have been sent to the list > > that I haven't yet applied or rejected: > > > > [PATCH] generate debug_frame info for __syscall_cp_asm (i386) so gdb can get backtrace > > [PATCH] fmtmsg: verify that label is in the correct format. > > [PATCH] replace 'hlt' by 'ud2' in i386/x32/x86_64 a_crash implementations > > [PATCH] conforming strverscmp() implementation > > > > There are also a few patches from nsz on the radar: > > > > http://port70.net/~nsz/musl/0001-add-IPTOS_CLASS_-macros-to-netinet-ip.h.patch > > http://port70.net/~nsz/musl/0001-complex-fix-ctanh-0-i-nan-and-ctanh-0-i-inf.patch > > http://port70.net/~nsz/musl/0001-inet_pton-clean-up.patch > > > > and the BRE extensions that are still under discussion, and possibly > > some cleanup of some always-false null checks in the failure path of > > regcomp. > > > > There's also the idea of changing getlogin[_r] to probe the actual > > controlling terminal and its owner to get the "logged in user" rather > > than just using $LOGNAME. I've done some work on this but it's not > > done and not clean for commit. > > > > Anything else I'm missing? Most of this probably won't go in the > > release but I at least want to make sure we have a good inventory of > > what's still pending. > > > > i forgot to do this one in elf.h: > > -#define SHF_EXCLUDE (1 << 31) > +#define SHF_EXCLUDE (1U << 31) > > (there is no other invalid <<31) This was discussed quite a bit on libc-alpha (glibc list) and it seems the consensus there is that changing the type to unsigned is potentially dangerous and it would be better to use (-0x7fffffff-1) or perhaps ((1<<30) * -2) if it's more clear. What do you think? Rich