From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Pending patches & other changes
Date: Tue, 28 Apr 2015 15:55:06 +0200 [thread overview]
Message-ID: <20150428135505.GC11625@port70.net> (raw)
In-Reply-To: <20150428134647.GN17573@brightrain.aerifal.cx>
* Rich Felker <dalias@libc.org> [2015-04-28 09:46:47 -0400]:
> On Tue, Apr 28, 2015 at 11:43:21AM +0200, Szabolcs Nagy wrote:
> > i forgot to do this one in elf.h:
> >
> > -#define SHF_EXCLUDE (1 << 31)
> > +#define SHF_EXCLUDE (1U << 31)
> >
> > (there is no other invalid <<31)
>
> This was discussed quite a bit on libc-alpha (glibc list) and it seems
> the consensus there is that changing the type to unsigned is
> potentially dangerous and it would be better to use (-0x7fffffff-1) or
> perhaps ((1<<30) * -2) if it's more clear. What do you think?
>
the glibc bikeshed ended with florian saying
"I thought some more about this, and have changed my opinion completely.
Making the constant unsigned is less risky than making it negative
because of potential sign extension issues."
https://sourceware.org/ml/libc-alpha/2015-04/msg00264.html
and they committed the original 1U<<31 patch today
next prev parent reply other threads:[~2015-04-28 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 3:48 Rich Felker
2015-04-28 9:43 ` Szabolcs Nagy
2015-04-28 13:46 ` Rich Felker
2015-04-28 13:55 ` Szabolcs Nagy [this message]
2015-05-01 17:42 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428135505.GC11625@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).