mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] force LTO to be disabled when compiling dlstart.lo
Date: Tue, 28 Apr 2015 23:22:42 -0400	[thread overview]
Message-ID: <20150429032242.GS17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <alpine.LNX.2.11.1504282208190.22867@monopod.intra.ispras.ru>

On Tue, Apr 28, 2015 at 10:23:37PM +0300, Alexander Monakov wrote:
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57703
> > 
> > I have an interesting solution to this problem: get rid of the
> > top-level asm and instead put it inside the function with 2 additional
> > lines:
> > 
> > - At the top, "jmp 9f" or equivalent.
> > - At the bottom, "9:".
> > 
> > Now the asm can't be separated from the function because it's part of
> > it. Would that work?
> 
> I think it would avoid the LTO partitioning issue, but it would also be a step
> back in terms of solving their original problem, which was to avoid duplicates
> of syscall entry sequence being potentially emitted.

Syscall entry sequences? I don't follow. Even if you meant "ELF entry
points" which sounds more plausible I'm still not sure how duplicates
would be emitted. I guess the concern is that if it's in a function
the asm block, even if it's volatile, could be emitted in more than
one place (e.g. a ptr-is-aligned branch and a ptr-is-misaligned
branch); it just has to execute the right number of times. So yes, if
this is what you mean, then I agree my solution is problematic and
probably best avoided.

> As another GCC
> discussion mentions, they started using toplevel asm there after they found
> they couldn't instruct Clang not do duplicate that function, unlike they could,
> with function attributes, tame GCC.

Interesting.

Rich


      reply	other threads:[~2015-04-29  3:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28  6:12 Andre McCurdy
2015-04-28  8:35 ` Alexander Monakov
2015-04-28  8:45   ` Alexander Monakov
2015-04-28 13:43   ` Rich Felker
2015-04-28 14:48     ` Khem Raj
2015-04-28 18:41     ` Alexander Monakov
2015-04-28 18:50       ` Alexander Monakov
2015-04-28 18:58         ` Rich Felker
2015-04-28 19:23           ` Alexander Monakov
2015-04-29  3:22             ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150429032242.GS17573@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).