From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Re: building musl libc.so with gcc -flto
Date: Thu, 30 Apr 2015 19:44:51 -0400 [thread overview]
Message-ID: <20150430234451.GY17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <5542949D.8000509@kernel.org>
On Thu, Apr 30, 2015 at 01:46:21PM -0700, Andy Lutomirski wrote:
> On 04/22/2015 07:23 PM, Rich Felker wrote:
> >On Wed, Apr 22, 2015 at 03:48:52PM -0700, Andre McCurdy wrote:
> >>Hi all,
> >>
> >>Below are some observations from building musl libc.so with gcc's -flto
> >>(link time optimization) option.
> >
> >Interesting!
> >
> >>1) With today's master (afbcac68), adding -flto to CFLAGS causes the
> >>build to fail:
> >>
> >> | `_dlstart_c' referenced in section `.text' of /tmp/cc8ceNIy.ltrans0.ltrans.o: defined in discarded section `.text' of src/ldso/dlstart.lo (symbol from plugin)
> >> | collect2: error: ld returned 1 exit status
> >> | make: *** [lib/libc.so] Error 1
> >>
> >>Reverting f1faa0e1 (make _dlstart_c function use hidden visibility)
> >>seems to be a workaround.
> >
> >I think the problem is that LTO is garbage collecting "unused" symbols
> >before it gets to the step of linking with asm for which there is no
> >IR code, thereby losing anything that's only referenced from asm. A
> >better workaround might be to define _dlstart_c with a different name
> >as a non-hidden function (e.g. call it __dls1) and then make
> >_dlstart_c a hidden alias for it via:
> >
> >__attribute__((__visibility__("hidden")))
> >void _dlstart_c(size_t *, size_t *);
> >
> >weak_alias(__dls1, _dlstart_c);
> >
> >If you get a chance to try that, let me know if it works. Another
> >option might be adding -Wl,-u,_dlstart_c to LDFLAGS.
>
> Wouldn't adding __attribute__((externally_visible)) to the relevant
> symbols be more appropriate? It's intended to solve exactly this
> problem.
I'm not clear whether it would be reliable to use this or not.
Semantically externally_visible and visibility=hidden are
contradictory. Even if we weren't trying to avoid relying on
additional GNU C features, I think it would be a bad idea to rely on
this working since the behavior under such contradictory annotations
could potentially vary widely between compilers.
Rich
next prev parent reply other threads:[~2015-04-30 23:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 22:48 Andre McCurdy
2015-04-23 2:23 ` Rich Felker
2015-04-23 5:34 ` Andre McCurdy
2015-04-23 9:45 ` Rich Felker
2015-04-28 0:16 ` Andre McCurdy
2015-04-28 0:24 ` Rich Felker
2015-04-28 6:23 ` Andre McCurdy
2015-04-28 13:44 ` Rich Felker
2015-04-29 1:42 ` Andre McCurdy
2015-04-29 3:27 ` Rich Felker
2015-05-01 5:48 ` Andre McCurdy
2015-05-01 10:10 ` Szabolcs Nagy
2015-05-01 15:49 ` Rich Felker
2015-04-30 20:46 ` Andy Lutomirski
2015-04-30 23:44 ` Rich Felker [this message]
2015-05-01 6:57 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430234451.GY17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).