From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Return rv if memory is not 'calloc'ed in getgrent_a
Date: Fri, 1 May 2015 12:34:04 -0400 [thread overview]
Message-ID: <20150501163404.GB17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150501155010.GA17573@brightrain.aerifal.cx>
On Fri, May 01, 2015 at 11:50:10AM -0400, Rich Felker wrote:
> On Fri, May 01, 2015 at 05:17:37AM -0700, Kevin Bowling wrote:
> > >From 714875b1a614c4ac3b7a04a9d419b7f57d28e336 Mon Sep 17 00:00:00 2001
> > From: Kevin Bowling <kevin.bowling@kev009.com>
> > Date: Fri, 1 May 2015 05:11:12 -0700
> > Subject: [PATCH] Return rv if memory is not 'calloc'ed in getgrent_a
> >
> > ---
> > src/passwd/getgrent_a.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/passwd/getgrent_a.c b/src/passwd/getgrent_a.c
> > index ecd2f2e..80fbc42 100644
> > --- a/src/passwd/getgrent_a.c
> > +++ b/src/passwd/getgrent_a.c
> > @@ -48,7 +48,7 @@ int __getgrent_a(FILE *f, struct group *gr, char **line,
> > size_t *size, char ***m
> > rv = errno;
> > free(*line);
> > *line = 0;
> > - return 0;
> > + return rv;
> > }
> > if (*mems) {
> > mem[0][0] = mems;
> > --
> > 2.3.7
>
> There's definitely a bug here but I don't think this patch fixes it.
> The exit code, which needs to be run, is still bypassed. There needs
> to be a "goto end" or similar instead of return, I think.
Should be fixed in commit 58fa856960d3073bcf84adac8e8bd6c555674271.
Let me know if you think there's still a problem. Thanks for the bug
report!
Rich
prev parent reply other threads:[~2015-05-01 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 12:17 Kevin Bowling
2015-05-01 15:50 ` Rich Felker
2015-05-01 16:34 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501163404.GB17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).