From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix futimes(fd, 0)
Date: Wed, 6 May 2015 19:19:01 -0400 [thread overview]
Message-ID: <20150506231901.GO17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150506225518.GB29035@port70.net>
On Thu, May 07, 2015 at 12:55:19AM +0200, Szabolcs Nagy wrote:
> * Felix Janda <felix.janda@posteo.de> [2015-05-07 00:10:28 +0200]:
> > Pass on 0 to futimens without trying to dereference it.
>
> is there a reason to accept 0 argument?
>
> there are other cases when the libc has to do fixups
> to the passed arguments and it dereferences the pointer
> which should be valid
Yes, see the man page:
http://man7.org/linux/man-pages/man3/futimes.3.html
It defers to utimes for the actual behavior, which is a standard
(albeit deprecated) function, and has specified behavior for the null
pointer case.
Rich
next prev parent reply other threads:[~2015-05-06 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 22:10 Felix Janda
2015-05-06 22:55 ` Szabolcs Nagy
2015-05-06 23:19 ` Rich Felker [this message]
2015-05-06 22:55 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506231901.GO17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).