mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Re: [PATCH v2] First prototype of script which adds CFI directives to x86 asm
Date: Wed, 13 May 2015 22:32:59 -0400	[thread overview]
Message-ID: <20150514023259.GA17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150513173646.GA2951@alex-ThinkPad-L530>

On Wed, May 13, 2015 at 07:36:46PM +0200, Alex Dowad wrote:
> Thanks to Szabolcs Nagy for your reply!
> 
> > it might make sense to have a make rule that produces the cfi asm for inspection
> 
> Any opinions from others on this?

I'm not sure. It's more clutter. It could be useful for debugging
issues, but so could intermediate .s files from the compiler before
making .o files, and in that case you just have to make them manually
if you want.

> > i wonder if a configure check for .cfi support should be added: in theory
> > an assembler may not support it (tcc?)
> 
> Sure, I can do this. If debugging is not enabled, it doesn't make much sense
> to use the CFI script either.
> 
> Would adding another variable to config.mak, something like GENERATE_CFI=yes
> (or something like that) be acceptable?

Perhaps configure should generate an AS_CMD variable or something,
making it just plain $CC for non-debug builds or when the CFI stuff
isn't supported, and something that wraps the call to $CC when CFI is
supported and desired (debug).

Rich


      reply	other threads:[~2015-05-14  2:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 17:36 Alex Dowad
2015-05-14  2:32 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514023259.GA17573@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).