From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7638 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH v2] First prototype of script which adds CFI directives to x86 asm Date: Wed, 13 May 2015 22:32:59 -0400 Message-ID: <20150514023259.GA17573@brightrain.aerifal.cx> References: <20150513173646.GA2951@alex-ThinkPad-L530> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1431570800 10743 80.91.229.3 (14 May 2015 02:33:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 May 2015 02:33:20 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7650-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 14 04:33:19 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YsixZ-0001jH-Lu for gllmg-musl@m.gmane.org; Thu, 14 May 2015 04:33:17 +0200 Original-Received: (qmail 1836 invoked by uid 550); 14 May 2015 02:33:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 1813 invoked from network); 14 May 2015 02:33:13 -0000 Content-Disposition: inline In-Reply-To: <20150513173646.GA2951@alex-ThinkPad-L530> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7638 Archived-At: On Wed, May 13, 2015 at 07:36:46PM +0200, Alex Dowad wrote: > Thanks to Szabolcs Nagy for your reply! > > > it might make sense to have a make rule that produces the cfi asm for inspection > > Any opinions from others on this? I'm not sure. It's more clutter. It could be useful for debugging issues, but so could intermediate .s files from the compiler before making .o files, and in that case you just have to make them manually if you want. > > i wonder if a configure check for .cfi support should be added: in theory > > an assembler may not support it (tcc?) > > Sure, I can do this. If debugging is not enabled, it doesn't make much sense > to use the CFI script either. > > Would adding another variable to config.mak, something like GENERATE_CFI=yes > (or something like that) be acceptable? Perhaps configure should generate an AS_CMD variable or something, making it just plain $CC for non-debug builds or when the CFI stuff isn't supported, and something that wraps the call to $CC when CFI is supported and desired (debug). Rich