From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7639 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v3] Build process uses script to add CFI directives to x86 asm Date: Wed, 13 May 2015 22:57:20 -0400 Message-ID: <20150514025720.GB17573@brightrain.aerifal.cx> References: <1431539679-4265-1-git-send-email-alexinbeijing@gmail.com> <20150513192252.GF31118@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1431572258 30721 80.91.229.3 (14 May 2015 02:57:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 May 2015 02:57:38 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7651-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 14 04:57:37 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YsjL6-0002LJ-P6 for gllmg-musl@m.gmane.org; Thu, 14 May 2015 04:57:36 +0200 Original-Received: (qmail 18100 invoked by uid 550); 14 May 2015 02:57:35 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 18071 invoked from network); 14 May 2015 02:57:34 -0000 Content-Disposition: inline In-Reply-To: <20150513192252.GF31118@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7639 Archived-At: On Wed, May 13, 2015 at 09:22:52PM +0200, Szabolcs Nagy wrote: > * Alex Dowad [2015-05-13 19:54:39 +0200]: > > > > I've noticed that using tempfiles for the augmented asm has a drawback: > > In the source file/line debugging info generated by the assembler, it records > > the source file as "/tmp/". Then, when you try to debug a program > > which is linked against the resulting musl, GDB tries to open "/tmp/" > > to show in the source window. > > > > Suggestions?? Perhaps generate .cfi.s files as Szabolcs suggested?? > > > > you can use > > .file "foo.s" One question -- will the fact that the line numbers don't match up interfere with debugging? If so, the CFI generation should add the directives to existing lines separated by ;'s rather than inserting lines. > > diff --git a/Makefile b/Makefile > > index 6559295..9aefd62 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -118,7 +118,7 @@ $(foreach s,$(wildcard src/*/$(ARCH)*/*.s),$(eval $(call mkasmdep,$(s)))) > > $(CC) $(CFLAGS_ALL_STATIC) -c -o $@ $(dir $<)$(shell cat $<) > > > > %.o: $(ARCH)/%.s > > - $(CC) $(CFLAGS_ALL_STATIC) -c -o $@ $< > > + tools/aswrap.sh $< $@ $(ARCH) "$(CC) $(CFLAGS_ALL_STATIC)" > > > > i think passing down the build command that way is not ok The quoting is probably off, but otherwise it doesn't look so bad. > " may be used inside CFLAGS (and there are other shell quote issues) > it hides the build command in the make output > it's not clear if the build correctly handles if CC fails Do you have a better design in mind? > > +function get_const1() { > > + # for instructions with 2 operands, get 1st operand (assuming it is constant) > > + match($0, /-?(0x[0-9a-fA-F]+|[0-9]+),/) > > + return parse_const(substr($0, RSTART, RLENGTH-1)) > > +} > > it only matches with immediate , > > i'd just clean the whitespaces up so you dont have to add \s* or \s+ > to every regex (see below) > > awk converts strings to numbers, but hex is unfortunately not guaranteed > to be supported (otherwise strtod conversion rules apply) > > but you can implement parse_const(s) as > > sign = sub(/^-/,"",s) > hex = sub(/^0x/,"",s) > if (hex) > n = hex2int(s) > else > n = s+0 > return sign ? -n : n > > this does not handle binary (0b11) and octal (0123) asm consts > (i think you should check for those and emit a warning). Is 0b something that could even be relied upon? We generally use a minimal asm dialect without extensions that real or hypothetical alternate assemblers might not have. I'm happy with a YAGNI approach to the CFI generation. > > +/^.global\s+\w+/ { > > + globals[$2] = 1 > > may be spelt as .globl too Yes, that might be used somewhere. > > +/pushl?/ { > > + if (match($0, /\s+%(ax|bx|cx|dx|di|si|bp|sp)/)) > > + adjust_sp_offset(2) > > + else > > + adjust_sp_offset(4) > > +} > > i think > > pushl $123 > push $123 > > are different How so? Likewise I don't think the stuff for 2-byte push/pop is terribly useful. It's not a meaningful operation to be performing in 32-bit code. Rich