From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Eliminating preference for avoiding thread pointer? Cost on MIPS?
Date: Sat, 16 May 2015 02:19:33 -0400 [thread overview]
Message-ID: <20150516061933.GI17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150516035544.GA4274@brightrain.aerifal.cx>
On Fri, May 15, 2015 at 11:55:44PM -0400, Rich Felker wrote:
> Traditionally, musl has gone to pretty great lengths to avoid
> depending on the thread pointer. The original reason was that it was
> not always initialized, and when it was, the init was lazy. This
> resulted in a lot of cruft, where we would have lots of constructs of
> the form:
>
> bar = some_predicate ? __pthread_self()->foo : global_foo
>
> or similar. Being that these predicates depend(ed) on globals, they
> were/are rather expensive in position-independent code on most archs.
> Now that the thread pointer is always initialized at startup (since
> 1.1.0) and assumed to have succeeded (since 1.1.9; musl now performs
> HCF if it fails), this seems to be an unnecessary cost. Not only does
> it cost cycles; it also has a complexity cost in terms of code to
> maintain the state of the predicates (e.g. the atomics for locale
> state) and in terms of libc-internal assumptions. So I'd like to just
> use the thread pointer directly wherever it makes sense, and take
> advantage of the fact that we have it.
>
> [...]
>
> So I think, whatever the performance results end up being, we have an
> acceptable path forward to use the (possibly virtual) thread pointer
> unconditionally throughout musl.
Just committed the first stage of this work:
http://git.musl-libc.org/cgit/musl/commit/?id=68630b55c0c7219fe9df70dc28ffbf9efc8021d8
If there are old-MIPS performance regressions we'll fix them at the
arch level rather than keeping this cruft all over the source.
Rich
next prev parent reply other threads:[~2015-05-16 6:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 3:55 Rich Felker
2015-05-16 6:19 ` Rich Felker [this message]
2015-05-16 16:33 ` Isaac Dunham
2015-05-16 16:48 ` Rich Felker
2015-05-18 19:35 ` Andre McCurdy
2015-05-18 20:16 ` Rich Felker
2015-05-18 20:20 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516061933.GI17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).