mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH v2] When building, don't use compiler flags which cause warnings
Date: Tue, 26 May 2015 23:14:43 -0400	[thread overview]
Message-ID: <20150527031443.GI17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <5883C613-AE68-4B6D-AAAA-F8ED3BEECADA@shiz.me>

On Wed, May 27, 2015 at 04:22:59AM +0200, Shiz wrote:
> > On 26 May 2015, at 21:57, Alex Dowad <alexinbeijing@gmail.com> wrote:
> > 
> > 
> > 
> > On 26/05/15 21:36, Rich Felker wrote:
> > Hmm. -Werror=unknown-warning-option causes configure to disable -Wno-unused-but-set-variable.
> > But it doesn't do anything for other ignored options. It causes problems when building with
> > gcc as well.
> > 
> > This isn't a big issue; I'd suggest it's better not to get stuck on it.
> > 
> > Thanks, AD
> 
> clang also has -Werror=unused-command-line-argument, which I imagine would work better,

I think we _don't_ want this in our final CFLAGS (in fact we may want
the opposite, Wno-...) because it will probably error out on linker
options in CFLAGS or C compiler options in assembler invocations.

But if it detects unknown options, we could use it just at configure
time (if it's supported) to help determine when options are not
supported.

> possibly in tandem with -Werror=unknown-warning option if those gcc problems can be weeded out.

Yes.

Rich


  reply	other threads:[~2015-05-27  3:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 17:51 [PATCH] When building, don't use flags which cause compiler warning Alex Dowad
2015-05-26 18:18 ` Rich Felker
2015-05-26 18:36   ` [PATCH v2] When building, don't use compiler flags which cause warnings Alex Dowad
2015-05-26 18:47     ` Rich Felker
2015-05-26 18:55       ` Alex Dowad
2015-05-26 19:36         ` Rich Felker
2015-05-26 19:57           ` Alex Dowad
2015-05-27  2:22             ` Shiz
2015-05-27  3:14               ` Rich Felker [this message]
2015-05-27 12:30                 ` Shiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150527031443.GI17573@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).