From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7781 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH v2] When building, don't use compiler flags which cause warnings Date: Tue, 26 May 2015 23:14:43 -0400 Message-ID: <20150527031443.GI17573@brightrain.aerifal.cx> References: <20150526181830.GD17573@brightrain.aerifal.cx> <1432665405-26308-1-git-send-email-alexinbeijing@gmail.com> <20150526184723.GE17573@brightrain.aerifal.cx> <5564C197.6020404@gmail.com> <20150526193611.GH17573@brightrain.aerifal.cx> <5564D020.1020209@gmail.com> <5883C613-AE68-4B6D-AAAA-F8ED3BEECADA@shiz.me> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1432696500 24857 80.91.229.3 (27 May 2015 03:15:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 May 2015 03:15:00 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7793-gllmg-musl=m.gmane.org@lists.openwall.com Wed May 27 05:14:59 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YxRo2-00055T-Lx for gllmg-musl@m.gmane.org; Wed, 27 May 2015 05:14:58 +0200 Original-Received: (qmail 27731 invoked by uid 550); 27 May 2015 03:14:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 27707 invoked from network); 27 May 2015 03:14:56 -0000 Content-Disposition: inline In-Reply-To: <5883C613-AE68-4B6D-AAAA-F8ED3BEECADA@shiz.me> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7781 Archived-At: On Wed, May 27, 2015 at 04:22:59AM +0200, Shiz wrote: > > On 26 May 2015, at 21:57, Alex Dowad wrote: > > > > > > > > On 26/05/15 21:36, Rich Felker wrote: > > Hmm. -Werror=unknown-warning-option causes configure to disable -Wno-unused-but-set-variable. > > But it doesn't do anything for other ignored options. It causes problems when building with > > gcc as well. > > > > This isn't a big issue; I'd suggest it's better not to get stuck on it. > > > > Thanks, AD > > clang also has -Werror=unused-command-line-argument, which I imagine would work better, I think we _don't_ want this in our final CFLAGS (in fact we may want the opposite, Wno-...) because it will probably error out on linker options in CFLAGS or C compiler options in assembler invocations. But if it detects unknown options, we could use it just at configure time (if it's supported) to help determine when options are not supported. > possibly in tandem with -Werror=unknown-warning option if those gcc problems can be weeded out. Yes. Rich