From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7806 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: More on warning cleanup Date: Thu, 28 May 2015 03:29:22 -0400 Message-ID: <20150528072922.GS17573@brightrain.aerifal.cx> References: <20150528050853.GA8590@brightrain.aerifal.cx> <5566BBDC.5080805@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1432798182 24487 80.91.229.3 (28 May 2015 07:29:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 May 2015 07:29:42 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7818-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 28 09:29:40 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YxsG3-0002ZS-2B for gllmg-musl@m.gmane.org; Thu, 28 May 2015 09:29:39 +0200 Original-Received: (qmail 21770 invoked by uid 550); 28 May 2015 07:29:35 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 21752 invoked from network); 28 May 2015 07:29:34 -0000 Content-Disposition: inline In-Reply-To: <5566BBDC.5080805@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7806 Archived-At: On Thu, May 28, 2015 at 08:55:24AM +0200, Alex Dowad wrote: > >Are these any other warnings we should enable? > Are you interested in warnings provided by clang, but not by gcc? Possibly. > I've noticed that there are a few things in musl which clang warns > about, but gcc doesn't; such as expressions where operator > precedence might be confusing to some, and indexing into strings > using + (it wants you to use [] instead). Only interested in warnings that catch non-portable constructs, near-certain bugs (e.g. UB if the code is reached), typos (unused warnings help here), etc. Not interested in coding style policing, and definitely not interested in warnings that are intended for JS or Python programmers trying to write their first C program. :-) Rich