From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7812 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: More on warning cleanup Date: Thu, 28 May 2015 13:18:44 -0400 Message-ID: <20150528171844.GU17573@brightrain.aerifal.cx> References: <20150528050853.GA8590@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1432833548 12881 80.91.229.3 (28 May 2015 17:19:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 May 2015 17:19:08 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7824-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 28 19:19:02 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Yy1SN-0003Ig-6G for gllmg-musl@m.gmane.org; Thu, 28 May 2015 19:18:59 +0200 Original-Received: (qmail 8077 invoked by uid 550); 28 May 2015 17:18:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 8057 invoked from network); 28 May 2015 17:18:56 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:7812 Archived-At: On Thu, May 28, 2015 at 03:57:23PM +0200, Shiz wrote: > > On 28 May 2015, at 07:08, Rich Felker wrote: > > > > Since compilers differ in what warnings they include in -Wall, I'd > > like to remove -Wall (followed by a bunch of -Wno-*) from musl's > > --enable-warnings and instead individually turn on the warnings we > > want. > > Sounds like a good idea, if only for consistency between compilers. > > > One other issue to consider is how to get rid of enabled-by-default > > warnings we don't want. On GCC they're impossible to turn off > > individually, but unobtrusive; only -w can turn them off, but -w is > > permanent and overrides all later -W options. On cparser, a lot of > > crap is turned on by default, but -w turns it off and is then > > overridable by subsequent -W options. Not sure about clang. > > clang mimics this behaviour, for what it’s worth. The only thing that > will enable warnings again is -pedantic-errors, which is rather unfortunate. > I presume GCC behaves the same way. I think this is a good argument that cparser should have its own separate option to reset all on-by-default warnings to off, or that it should just get rid of them -- users who want warnings should pass -Wall or specific options. I'll pass a link to this thread their way. If they don't want to change it there are ugly ways we could test for the behavior (compile code almost certain to get warnings with -Werror, then see if -w -Wall -Werror also errors). Rich