mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/2] add musl-clang, a wrapper for system clang installs
Date: Fri, 29 May 2015 13:03:49 -0400	[thread overview]
Message-ID: <20150529170349.GK17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <1432918126-27741-1-git-send-email-hi@shiz.me>

On Fri, May 29, 2015 at 06:48:45PM +0200, Shiz wrote:
> +# prevent clang from running the linker (and erroring) on no input.
> +sflags=
> +eflags=
> +for x ; do
> +    case "$x" in
> +        -l*) input=1 ;;
> +        -*) input= ;;
> +        *) input=1 ;;
> +    esac
> +    if test "$input" ; then
> +        sflags="-l-user-start"
> +        eflags="-lc -l-user-end"
> +        break
> +    fi
> +done

This logic looks wrong. For example, "-L foo" would result in input=1,
no? And same for any other options with arguments.

Rich


  parent reply	other threads:[~2015-05-29 17:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 16:48 Shiz
2015-05-29 16:55 ` [PATCH 2/2] build: overhaul wrapper script system for multiple wrapper support Shiz
2015-06-01  3:18   ` Rich Felker
2015-06-01 14:15     ` Shiz
2015-06-01 14:47       ` Rich Felker
2015-06-01 15:39         ` Shiz
2015-06-01 16:03           ` Rich Felker
2015-05-29 17:03 ` Rich Felker [this message]
2015-05-29 17:11   ` [PATCH 1/2] add musl-clang, a wrapper for system clang installs Shiz
2015-05-29 17:13     ` Rich Felker
2015-05-29 17:35       ` Shiz
2015-05-29 18:43 ` [PATCH v2] " Shiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529170349.GK17573@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).