From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] build: overhaul wrapper script system for multiple wrapper support
Date: Mon, 1 Jun 2015 12:03:44 -0400 [thread overview]
Message-ID: <20150601160344.GA21135@brightrain.aerifal.cx> (raw)
In-Reply-To: <09CD8E2A-6438-48AC-9D60-F661471EE00F@shiz.me>
On Mon, Jun 01, 2015 at 05:39:46PM +0200, Shiz wrote:
> > On 01 Jun 2015, at 16:47, Rich Felker <dalias@libc.org> wrote:
> >
> > There are two reasons I prefer the approach I described:
> >
> > 1. It's better not to auto-enable wrappers unless we're pretty
> > confident they work. The wrappers are not magically universal; they're
> > a way to use musl with a preexisting non-musl-targeted toolchain that
> > meets a fairly large set of internal assumptions, and they won't
> > necessarily work with arbitrary toolchains. In particular I'm pretty
> > sure musl-gcc does not work with Rob's toolchains from Aboriginal
> > Linux that are using their own wrapper (named gcc) around an internal
> > gcc elsewhere, and presumably (being uclibc based) these would even be
> > detected as "ok for wrapper”.
>
> I’d like to note that a __GLIBC__ check would not help here either
> presumably, as uclibc defines __GLIBC__ as well. :)
Yes, that's what I was trying to say.
> So I see your use case for testing in C code itself as opposed to testing
> compiler features. That being said, I’m still not at all a fan of __GLIBC__,
> for reasons mentioned in the previous post. While a false-positive is worse
> than a false-negative, I feel just solely testing for this provides a large
> opportunity for false-negatives, and even some false positives as you yourself
> mentioned in point one.
I'm not aware of any real-world false-negatives. A Bionic-based system
would probably be one, if any such system with a compiler toolchain
exists, but depending on the properties of the toolchain that might
even be a proper negative rather than a false-negative, so I'd
actually prefer to research whether the wrappers work for such
Bionic-based toolchains and then enable them explicitly if they do,
rather than just assuming they work.
> It’s a tough thing to check thoroughly and accurately, but I do not think
> checking __GLIBC__ is at all the solution either.
Still open to more options.
Rich
next prev parent reply other threads:[~2015-06-01 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 16:48 [PATCH 1/2] add musl-clang, a wrapper for system clang installs Shiz
2015-05-29 16:55 ` [PATCH 2/2] build: overhaul wrapper script system for multiple wrapper support Shiz
2015-06-01 3:18 ` Rich Felker
2015-06-01 14:15 ` Shiz
2015-06-01 14:47 ` Rich Felker
2015-06-01 15:39 ` Shiz
2015-06-01 16:03 ` Rich Felker [this message]
2015-05-29 17:03 ` [PATCH 1/2] add musl-clang, a wrapper for system clang installs Rich Felker
2015-05-29 17:11 ` Shiz
2015-05-29 17:13 ` Rich Felker
2015-05-29 17:35 ` Shiz
2015-05-29 18:43 ` [PATCH v2] " Shiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601160344.GA21135@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).