mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: musl@lists.openwall.com
Subject: Re: stable 1.1.9 & current GIT broken on mips
Date: Thu, 4 Jun 2015 12:07:08 -0400	[thread overview]
Message-ID: <20150604160708.GQ17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <5570411B.40307@dd-wrt.com>

On Thu, Jun 04, 2015 at 02:14:19PM +0200, Sebastian Gottschall wrote:
> nbd gave me the following patch he found in the IRC. i tested it and
> its working
> 
> 
> diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c
> index 42930ad..f498327 100644
> --- a/src/ldso/dynlink.c
> +++ b/src/ldso/dynlink.c
> @@ -270,6 +270,8 @@ static void do_relocs(struct dso *dso, size_t
> *rel, size_t rel_size, size_t stri
>         for (; rel_size; rel+=stride, rel_size-=stride*sizeof(size_t)) {
>                 if (skip_relative && IS_RELATIVE(rel[1])) continue;
>                 type = R_TYPE(rel[1]);
> +               if (!type)
> +                       continue;
>                 sym_index = R_SYM(rel[1]);
>                 reloc_addr = (void *)(base + rel[0]);
>                 if (sym_index) {

Excellent. I've applied an equivalent fix to git master and it will be
in the 1.1.10 release (coming up soon).

Rich


  reply	other threads:[~2015-06-04 16:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02  9:09 time.h define NULL Tomasz Sterna
2015-06-02  9:35 ` Szabolcs Nagy
2015-06-02  9:38   ` Daniel Cegiełka
2015-06-02  9:41     ` Szabolcs Nagy
2015-06-02 11:16   ` Tomasz Sterna
2015-06-02 11:24     ` Szabolcs Nagy
2015-06-02 12:04       ` Tomasz Sterna
2015-06-02 15:57         ` stable 1.1.9 & current GIT broken on mips Sebastian Gottschall
2015-06-02 17:19           ` Rich Felker
2015-06-02 17:52             ` Sebastian Gottschall
2015-06-02 19:11               ` Rich Felker
2015-06-02 19:59                 ` Sebastian Gottschall
2015-06-04  4:04                   ` Rich Felker
2015-06-04  8:29                     ` Sebastian Gottschall
2015-06-04 12:14                     ` Sebastian Gottschall
2015-06-04 16:07                       ` Rich Felker [this message]
2015-06-06 15:42                         ` Anthony G. Basile
2015-06-06 15:59                           ` Anthony G. Basile
2015-06-02 11:32     ` time.h define NULL Jens Gustedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604160708.GQ17573@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --cc=s.gottschall@dd-wrt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).