From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Byte-based C locale, draft 1
Date: Sat, 6 Jun 2015 22:50:25 -0400 [thread overview]
Message-ID: <20150607025025.GC17573@brightrain.aerifal.cx> (raw)
In-Reply-To: <20150606214007.GA17398@brightrain.aerifal.cx>
On Sat, Jun 06, 2015 at 05:40:07PM -0400, Rich Felker wrote:
> Attached is the first draft of a proposed byte-based C locale. The
> patch is about 400 lines but most of it is context, because it's
> basically a lot of tiny changes spread out over lots of files.
> [...]
If we go forward with this, I think I can factor it into 3 parts:
1. Add checks for MB_CUR_MAX==1 and the bytelocale support they would
activate, and the CODEUNIT/IS_CODEUNIT macros needed for these code
paths. This patch would be a complete nop and would not even affect
codegen with a decent compiler since MB_CUR_MAX==4 is a constant
right now.
2. Introduce stdio saving of active LC_CTYPE at the time of stream
orientation (fwide) and save/restore of current locale around stdio
ops that need it (fputwc, fgetwc, ungetwc) and iconv usage of
multibyte functions. This patch would increase code size in a few
places but would not change behavior.
3. Replace the constant MB_CUR_MAX macro with a runtime-variable value
dependent on CURRENT_LOCALE->cat[LC_CTYPE]. This would actually
activate the byte-based C locale support. locale_impl.h is actually
already doing this, so I think I should remove that definition
before making any changes and only bring it back if/when stage 3
here is committed.
In principle stages 1 and 2 could be committed in either order;
they're independent. Stage 3 is also independent in what it touches,
but if it's already committed before stage 1/2, then committing stage
1 without stage 2 is a functional regression (stdio functions no
longer behave according to spec; iconv stops working in C locale).
Rich
next prev parent reply other threads:[~2015-06-07 2:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 21:40 Rich Felker
2015-06-06 22:39 ` Harald Becker
2015-06-06 23:10 ` Rich Felker
2015-06-06 23:59 ` Harald Becker
2015-06-07 0:24 ` Rich Felker
2015-06-07 23:59 ` Build option to disable locale [was: Byte-based C locale, draft 1] Harald Becker
2015-06-08 0:28 ` Josiah Worcester
2015-06-08 1:57 ` Harald Becker
2015-06-08 2:36 ` Rich Felker
2015-06-08 3:35 ` Harald Becker
2015-06-08 3:51 ` Josiah Worcester
2015-06-08 0:33 ` Rich Felker
2015-06-08 2:46 ` Harald Becker
2015-06-08 4:06 ` Rich Felker
2015-06-09 3:20 ` Isaac Dunham
2015-06-09 4:27 ` Rich Felker
2015-06-07 1:17 ` [PATCH] Byte-based C locale, draft 1 Rich Felker
2015-06-07 2:50 ` Rich Felker [this message]
2015-06-13 7:06 ` [PATCH] Byte-based C locale, draft 2 Rich Felker
2015-06-16 4:26 ` Rich Felker
2015-06-16 4:35 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150607025025.GC17573@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).